Bug 2280348

Summary:	Upgrade from Satellite 6.14.z to 6.15.z fails with ERF73-0602 [Foreman::PermissionMissingException]
Product:	Red Hat Satellite	Reporter:	Satyajit Das <sadas>
Component:	Users & Roles	Assignee:	Adam Ruzicka <aruzicka>
Status:	CLOSED MIGRATED	QA Contact:	Satellite QE Team <sat-qe-bz-list>
Severity:	high	Docs Contact:
Priority:	high
Version:	6.15.0	CC:	ahumbe, aruzicka, dhjoshi, ehelms, gformisa, mhulan, pdwyer, rlavi, saydas
Target Milestone:	Unspecified	Keywords:	MigratedToJIRA, PrioBumpGSS, Triaged, Upgrades
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-06-06 17:38:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Satyajit Das 2024-05-14 13:51:47 UTC

Description of problem:

Upgrade from Satellite 6.14.z to 6.15.z fails with ERF73-0602 [Foreman::PermissionMissingException]: some permissions were not found: [:view_lookup_values, :create_lookup_values, :edit_lookup_values, :destroy_lookup_values] (Foreman::PermissionMissingException)

Version-Release number of selected component (if applicable):

6.14.z to 6.15.z upgrade

How reproducible:

In the customer's env

Steps to Reproduce:

1. Follow the steps from the doc to upgrade from 6.14.z to 6.15.z 

https://docs.redhat.com/en/documentation/red_hat_satellite/6.15/html/upgrading_connected_red_hat_satellite_to_6.15/index

Actual results:
~~~~~~~~~~
2024-05-13 17:43:41 [ERROR ] [configure] May 13 17:38:44 valsat02.valtion.fi foreman[3106]: Exiting
2024-05-13 17:43:41 [ERROR ] [configure] May 13 17:38:44 valsat02.valtion.fi foreman[3106]: /usr/share/foreman/app/models/role.rb:346:in `permission_records': ERF73-0602 [Foreman::PermissionMissingException]: some permissions were not found: [:view_lookup_values, :create_lookup_values, :edit_lookup_values, :destroy_lookup_values] (Foreman::PermissionMissingException)
~~~~~~~~~~

Expected results:

The upgrade should be completed without any exceptions.


Additional info:
Executing the rake to recreate the permission fixed the issue.

~~~~~~~~~~~~~~~~
cat <<FIX | foreman-rake console
["view_lookup_values", "create_lookup_values", "edit_lookup_values", "destroy_lookup_values"].each do |per|
  Permission.find_or_create_by(:name => per)
end
FIX
~~~~~~~~~~~~~~~~

Comment 2 Adam Ruzicka 2024-05-23 13:36:12 UTC

What seems to be happening:
1) A new permission was added in foreman in https://github.com/theforeman/foreman/pull/9803
2) A role in foreman_ansible was extended to have the permission from 1) in https://github.com/theforeman/foreman_ansible/pull/633
3) When the installer runs, it skips explicit seeds (foreman-rake db:seed) because explicit seeds only run when the db was migrated
4) Seeds are supposed to be seeded when the rails process boots up, but because of the load order the plugin seems to be initialized before its dependencies (the permission in core) are seeded

Alternative reproducer:
1) Connect to postgres
2) Mangle your db
delete from filterings where permission_id in (select id from permissions where resource_type = 'LookupValue');
delete from permissions where resource_type = 'LookupValue';
3) systemctl restart foreman 

Alternative workaround:
Run foreman-rake db:seed, wait for it to finish and then carry on

Comment 3 Eric Helms 2024-06-06 17:38:59 UTC

This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "SAT-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.