Bug 2280377

Summary: Review Request: rust-below-ethtool - ethtool crate for below
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Davide Cavalca <davide>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: davide, package-review
Target Milestone: ---Flags: davide: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/below-ethtool
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-05-14 19:50:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2272252    

Description Michel Lind 2024-05-14 17:19:56 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-below-ethtool.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-below-ethtool-0.8.1-1.fc41.src.rpm

Description:
ethtool crate for below.

Fedora Account System Username: salimma

Comment 1 Fedora Review Service 2024-05-14 17:28:15 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7444525
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2280377-rust-below-ethtool/fedora-rawhide-x86_64/07444525-rust-below-ethtool/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Davide Cavalca 2024-05-14 17:55:23 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 3 Fedora Admin user for bugzilla script actions 2024-05-14 17:59:18 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-below-ethtool

Comment 4 Fedora Update System 2024-05-14 18:44:28 UTC
FEDORA-2024-c53feb16e7 (rust-below-ethtool-0.8.1-2.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c53feb16e7

Comment 5 Fedora Update System 2024-05-14 19:50:10 UTC
FEDORA-2024-c53feb16e7 (rust-below-ethtool-0.8.1-2.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.