Bug 2280552

Summary: koji fails to build with Python 3.13: KeyError: '__version__' (calling locals()) behavior is changed)
Product: [Fedora] Fedora Reporter: Karolina Surma <ksurma>
Component: kojiAssignee: Mike McLean <mikem>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: cstratak, kevin, ksurma, mhroncok, mikem, patrick
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: koji-1.34.1-2.fc41 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-06-19 00:19:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2244836    

Description Karolina Surma 2024-05-15 06:39:52 UTC
koji fails to build with Python 3.13.0b1.

+ /usr/bin/python3 setup.py bdist_wheel
Traceback (most recent call last):
  File "/builddir/build/BUILD/koji-1.34.0/setup.py", line 39, in <module>
    version=get_version(),
            ~~~~~~~~~~~^^
  File "/builddir/build/BUILD/koji-1.34.0/setup.py", line 29, in get_version
    return locals()['__version__']
           ~~~~~~~~^^^^^^^^^^^^^^^
KeyError: '__version__'

This behavior was reported to CPython: https://github.com/python/cpython/issues/118888 and assessed as expected due to PEP 667.

https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/07443432-koji/

For all our attempts to build koji with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/koji/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Miro Hrončok 2024-05-28 20:12:46 UTC
Upstream PR: https://pagure.io/koji/pull-request/4100

Comment 2 Miro Hrončok 2024-05-28 20:16:39 UTC
Downstream PR: https://src.fedoraproject.org/rpms/koji/pull-request/18