Bug 2280803

Summary:	Review Request: rust-avt - Asciinema virtual terminal
Product:	[Fedora] Fedora	Reporter:	Gustavo Costa <xfgusta>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Keywords:	AutomationTriaged
Target Release:	---	Flags:	decathorpe: fedora-review+
Hardware:	All
OS:	Linux
URL:	https://crates.io/crates/avt
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-06-08 23:11:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Gustavo Costa 2024-05-16 10:28:55 UTC

Spec URL: https://xfgusta.fedorapeople.org/pkgs/rust-avt.spec
SRPM URL: https://xfgusta.fedorapeople.org/pkgs/rust-avt-0.10.3-1.fc41.src.rpm

Description:
Asciinema virtual terminal.

Fedora Account System Username: xfgusta

Comment 1 Fedora Review Service 2024-05-16 11:21:44 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7449616
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2280803-rust-avt/fedora-rawhide-x86_64/07449616-rust-avt/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-06-04 16:05:12 UTC

Package looks good to me!

Note that, in general, I would not recommend to exclude "/examples" or "/tests" directories from packaged files.
It can have negative side effects that are not immediately obvious, for example, if there are examples or tests that are explicitly referenced in Cargo.toml instead of being auto-detected.

===

Package was generated with rust2rpm, simplifying the review.

✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Fedora Admin user for bugzilla script actions 2024-06-08 22:46:11 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-avt

Comment 4 Fedora Update System 2024-06-08 23:08:23 UTC

FEDORA-2024-f0af8fb787 (rust-avt-0.10.3-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-f0af8fb787

Comment 5 Fedora Update System 2024-06-08 23:11:22 UTC

FEDORA-2024-f0af8fb787 (rust-avt-0.10.3-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.