Bug 2280965

Summary: python-devtools fails to build with Python 3.13: INTERNALERROR> ValueError when running test suite
Product: [Fedora] Fedora Reporter: Karolina Surma <ksurma>
Component: python-devtoolsAssignee: Orphan Owner <extras-orphan>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: code, fti-bugs, jonathan, ksurma, mhroncok
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-08-23 13:02:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2260875, 2260877, 2300529, 2244836    

Description Karolina Surma 2024-05-17 11:47:06 UTC
python-devtools fails to build with Python 3.13.0b1.

/usr/bin/pytest --pyargs -k 'not test_repr_str and not test_executing_failure and not test_return_args and not test_colours and not test_insert_assert_no_pretty'
============================= test session starts ==============================
platform linux -- Python 3.13.0b1, pytest-7.4.3, pluggy-1.3.0
rootdir: /builddir/build/BUILD/python-devtools-0.12.2
configfile: pyproject.toml
testpaths: tests
plugins: devtools-0.12.2, mock-3.12.0
collected 110 items / 7 deselected / 103 selected

tests/test_ansi.py ..........                                            [  9%]
tests/test_custom_pretty.py .....s                                       [ 15%]
tests/test_expr_render.py FFFFFFFFFFFFFFFFF                              [ 32%]
tests/test_main.py FFFFF
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/_pytest/main.py", line 271, in wrap_session
INTERNALERROR>     session.exitstatus = doit(config, session) or 0
INTERNALERROR>                          ~~~~^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/_pytest/main.py", line 325, in _main
INTERNALERROR>     config.hook.pytest_runtestloop(session=session)
INTERNALERROR>     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/pluggy/_hooks.py", line 493, in __call__
INTERNALERROR>     return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)
INTERNALERROR>            ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/pluggy/_manager.py", line 115, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>            ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/pluggy/_callers.py", line 152, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>            ~~~~~~~~~~~~~~~~~~^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/pluggy/_result.py", line 114, in get_result
INTERNALERROR>     raise exc.with_traceback(exc.__traceback__)
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/pluggy/_callers.py", line 77, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/_pytest/main.py", line 350, in pytest_runtestloop
INTERNALERROR>     item.config.hook.pytest_runtest_protocol(item=item, nextitem=nextitem)
INTERNALERROR>     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/pluggy/_hooks.py", line 493, in __call__
INTERNALERROR>     return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)
INTERNALERROR>            ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/pluggy/_manager.py", line 115, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>            ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/pluggy/_callers.py", line 152, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>            ~~~~~~~~~~~~~~~~~~^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/pluggy/_result.py", line 114, in get_result
INTERNALERROR>     raise exc.with_traceback(exc.__traceback__)
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/pluggy/_callers.py", line 77, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/_pytest/runner.py", line 114, in pytest_runtest_protocol
INTERNALERROR>     runtestprotocol(item, nextitem=nextitem)
INTERNALERROR>     ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/_pytest/runner.py", line 133, in runtestprotocol
INTERNALERROR>     reports.append(call_and_report(item, "call", log))
INTERNALERROR>                    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/_pytest/runner.py", line 224, in call_and_report
INTERNALERROR>     report: TestReport = hook.pytest_runtest_makereport(item=item, call=call)
INTERNALERROR>                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/pluggy/_hooks.py", line 493, in __call__
INTERNALERROR>     return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)
INTERNALERROR>            ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/pluggy/_manager.py", line 115, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>            ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/pluggy/_callers.py", line 130, in _multicall
INTERNALERROR>     teardown[0].send(outcome)
INTERNALERROR>     ~~~~~~~~~~~~~~~~^^^^^^^^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/_pytest/skipping.py", line 266, in pytest_runtest_makereport
INTERNALERROR>     rep = outcome.get_result()
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/pluggy/_result.py", line 114, in get_result
INTERNALERROR>     raise exc.with_traceback(exc.__traceback__)
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/pluggy/_callers.py", line 77, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/_pytest/runner.py", line 368, in pytest_runtest_makereport
INTERNALERROR>     return TestReport.from_item_and_call(item, call)
INTERNALERROR>            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/_pytest/reports.py", line 362, in from_item_and_call
INTERNALERROR>     longrepr = item.repr_failure(excinfo)
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/_pytest/python.py", line 1833, in repr_failure
INTERNALERROR>     return self._repr_failure_py(excinfo, style=style)
INTERNALERROR>            ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/_pytest/nodes.py", line 486, in _repr_failure_py
INTERNALERROR>     return excinfo.getrepr(
INTERNALERROR>            ~~~~~~~~~~~~~~~^
INTERNALERROR>         funcargs=True,
INTERNALERROR>         ^^^^^^^^^^^^^^
INTERNALERROR>     ...<4 lines>...
INTERNALERROR>         truncate_locals=truncate_locals,
INTERNALERROR>         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>     )
INTERNALERROR>     ^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/_pytest/_code/code.py", line 701, in getrepr
INTERNALERROR>     return fmt.repr_excinfo(self)
INTERNALERROR>            ~~~~~~~~~~~~~~~~^^^^^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/_pytest/_code/code.py", line 989, in repr_excinfo
INTERNALERROR>     reprtraceback = self.repr_traceback(excinfo_)
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/_pytest/_code/code.py", line 914, in repr_traceback
INTERNALERROR>     self.repr_traceback_entry(entry, excinfo if last == entry else None)
INTERNALERROR>     ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/_pytest/_code/code.py", line 867, in repr_traceback_entry
INTERNALERROR>     path = self._makepath(entry_path)
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/_pytest/_code/code.py", line 883, in _makepath
INTERNALERROR>     np = bestrelpath(Path.cwd(), path)
INTERNALERROR>   File "/usr/lib/python3.13/site-packages/_pytest/pathlib.py", line 769, in bestrelpath
INTERNALERROR>     reldirectory = directory.relative_to(base)
INTERNALERROR>   File "/usr/lib64/python3.13/unittest/mock.py", line 1164, in __call__
INTERNALERROR>     return self._mock_call(*args, **kwargs)
INTERNALERROR>            ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib64/python3.13/unittest/mock.py", line 1168, in _mock_call
INTERNALERROR>     return self._execute_mock_call(*args, **kwargs)
INTERNALERROR>            ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib64/python3.13/unittest/mock.py", line 1223, in _execute_mock_call
INTERNALERROR>     raise effect
INTERNALERROR>   File "/builddir/build/BUILDROOT/python-devtools-0.12.2-1.fc41.x86_64/usr/lib/python3.13/site-packages/devtools/debug.py", line 170, in _process
INTERNALERROR>     path = path.relative_to(cwd)
INTERNALERROR>   File "/usr/lib64/python3.13/unittest/mock.py", line 1164, in __call__
INTERNALERROR>     return self._mock_call(*args, **kwargs)
INTERNALERROR>            ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib64/python3.13/unittest/mock.py", line 1168, in _mock_call
INTERNALERROR>     return self._execute_mock_call(*args, **kwargs)
INTERNALERROR>            ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/usr/lib64/python3.13/unittest/mock.py", line 1223, in _execute_mock_call
INTERNALERROR>     raise effect
INTERNALERROR> ValueError

https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/07449586-python-devtools/

For all our attempts to build python-devtools with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/python-devtools/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Karolina Surma 2024-06-12 15:00:11 UTC
*** Bug 2291670 has been marked as a duplicate of this bug. ***

Comment 2 Fedora Fails To Install 2024-06-19 19:59:49 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 3 Fedora Fails To Install 2024-07-13 08:02:08 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 4+ weeks.
This is the second reminder (step 4) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 4 Ben Beasley 2024-08-02 16:14:10 UTC
Now I see just one failing test:

=================================== FAILURES ===================================
________________________________ test_ast_expr _________________________________

    @pytest.mark.skipif(sys.version_info < (3, 9), reason='no indent on older versions')
    def test_ast_expr():
>       assert pformat(ast.parse('print(1, 2, round(3))', mode='eval')) == (
            "Expression("
            "\n    body=Call("
            "\n        func=Name(id='print', ctx=Load()),"
            "\n        args=["
            "\n            Constant(value=1),"
            "\n            Constant(value=2),"
            "\n            Call("
            "\n                func=Name(id='round', ctx=Load()),"
            "\n                args=["
            "\n                    Constant(value=3)],"
            "\n                keywords=[])],"
            "\n        keywords=[]))"
        )
E       AssertionError: assert 'Expression(\...value=3)])]))' == 'Expression(\...keywords=[]))'
E         
E         Skipping 267 identical leading characters in diff, use -v to show
E         - (value=3)],
E         ?           ^^
E         + (value=3)])]))
E         ?           ^^^^
E         -                 keywords=[])],
E         -         keywords=[]))

tests/test_prettier.py:490: AssertionError
=========================== short test summary info ============================
FAILED tests/test_prettier.py::test_ast_expr - AssertionError: assert 'Expres...
============ 1 failed, 94 passed, 8 skipped, 7 deselected in 0.51s =============

Comment 5 Ben Beasley 2024-08-02 16:16:35 UTC
Passing -vv to pytest:

=================================== FAILURES ===================================
________________________________ test_ast_expr _________________________________

    @pytest.mark.skipif(sys.version_info < (3, 9), reason='no indent on older versions')
    def test_ast_expr():
>       assert pformat(ast.parse('print(1, 2, round(3))', mode='eval')) == (
            "Expression("
            "\n    body=Call("
            "\n        func=Name(id='print', ctx=Load()),"
            "\n        args=["
            "\n            Constant(value=1),"
            "\n            Constant(value=2),"
            "\n            Call("
            "\n                func=Name(id='round', ctx=Load()),"
            "\n                args=["
            "\n                    Constant(value=3)],"
            "\n                keywords=[])],"
            "\n        keywords=[]))"
        )   
E       assert "Expression(\n    body=Call(\n        func=Name(id='print', ctx=Load()),\n        args=[\n            Constant(value=1),\n            Constant(value=2),\n            Call(\n                func=Name(id='round', ctx=Load()),\n                args=[\n                    Constant(value=3)])]))" == "Expression(\n    body=Call(\n        func=Name(id='print', ctx=Load()),\n        args=[\n            Constant(value=1),\n            Constant(value=2),\n            Call(\n                func=Name(id='round', ctx=Load()),\n                args=[\n                    Constant(value=3)],\n                keywords=[])],\n        keywords=[]))"
E
E           Expression(
E               body=Call(
E                   func=Name(id='print', ctx=Load()),
E                   args=[
E                       Constant(value=1),
E                       Constant(value=2),
E                       Call(
E                           func=Name(id='round', ctx=Load()),
E                           args=[
E         -                     Constant(value=3)],
E         ?                                       ^^
E         +                     Constant(value=3)])]))
E         ?                                       ^^^^
E         -                 keywords=[])],   
E         -         keywords=[]))

tests/test_prettier.py:490: AssertionError

Comment 6 Fedora Fails To Install 2024-08-13 00:02:39 UTC
This package has been orphaned.

You can pick it up at https://src.fedoraproject.org/rpms/python-devtools by clicking button "Take". If nobody picks it up, it will be retired and removed from a distribution.

Comment 7 Fedora Admin user for bugzilla script actions 2024-08-22 18:41:23 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 8 Miro HronĨok 2024-08-23 13:02:51 UTC
Automation has figured out the package is retired in rawhide.

If you like it to be unretired, please open a ticket at https://pagure.io/releng/new_issue?template=package_unretirement

Comment 9 Red Hat Bugzilla 2024-12-22 04:25:14 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days