Bug 2280997

Summary: Review Request: rust-stable-pattern - Stable port of std::str::Pattern and friends
Product: [Fedora] Fedora Reporter: wojnilowicz <lukasz.wojnilowicz>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: decathorpe: fedora-review+
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/stable-pattern
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-06-03 17:08:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description wojnilowicz 2024-05-17 16:45:27 UTC
Spec URL: https://wojnilowicz.fedorapeople.org/rust-stable-pattern.spec
SRPM URL: https://wojnilowicz.fedorapeople.org/rust-stable-pattern-0.1.0-1.fc39.src.rpm

Description:
Stable port of std::str::Pattern and friends.

Fedora Account System Username: wojnilowicz

It's in the dependency chain for building https://github.com/ActivityWatch/activitywatch (stable-pattern->rocket_http->rocket->aw-server-rust specifically)

One can see that it's working at https://copr.fedorainfracloud.org/coprs/wojnilowicz/activitywatch/

Comment 1 Fedora Review Service 2024-05-17 16:52:22 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7454834
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2280997-rust-stable-pattern/fedora-rawhide-x86_64/07454834-rust-stable-pattern/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-06-03 11:42:35 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass (one test disabled with explanation)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files (included manually from upstream, PR to add them was accepted)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

If you have time, it would be great if you could review one of my pending packages in return (for example, #2283858).

Comment 3 wojnilowicz 2024-06-03 15:38:40 UTC
Thanks and no problem in reviewing #2283858 :)

Comment 4 Fedora Admin user for bugzilla script actions 2024-06-03 16:04:35 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-stable-pattern

Comment 5 Fedora Update System 2024-06-03 16:28:48 UTC
FEDORA-2024-b662748460 (rust-stable-pattern-0.1.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-b662748460

Comment 6 Fedora Update System 2024-06-03 17:08:36 UTC
FEDORA-2024-b662748460 (rust-stable-pattern-0.1.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.