Bug 2281552

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7467144
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2281552-accessibility-inspector/fedora-rawhide-x86_64/07467144-accessibility-inspector/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Release seems like it should be 1.10.0 see:
https://download.kde.org/stable/accessibility-inspector/
There is also a signature available, should this be verified?

That is a pre-Gear version.  This package is joining KDE Gear as of 24.05, for which the version packaged is the beta.

Spec URL: https://yselkowitz.fedorapeople.org/accessibility-inspector.spec
SRPM URL: https://yselkowitz.fedorapeople.org/accessibility-inspector-24.05.0-1.fc41.src.rpm
Description: Accessibility Inspector is an inspector for your application accessibility tree. It lets you check all the items exposed via At-SPI, too.
Fedora Account System Username: yselkowitz

Created attachment 2034994 [details]
The .spec file difference from Copr build 7467144 to 7486940

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7486940
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2281552-accessibility-inspector/fedora-rawhide-x86_64/07486940-accessibility-inspector/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[-]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Creative Commons CC0 1.0", "BSD
     2-Clause License", "BSD 3-Clause License", "Creative Commons CC0 1.0
     and/or GNU Lesser General Public License, Version 3", "*No copyright*
     BSD 2-Clause License", "*No copyright* BSD 3-Clause License", "*No
     copyright* Creative Commons CC0 1.0", "GNU Library General Public
     License, Version 2.0", "GNU Lesser General Public License, Version
     2.1", "GNU Lesser General Public License, Version 3", "*No copyright*
     GNU Lesser General Public License, Version 3", "GNU Lesser General
     Public License, Version 2.1 and/or GNU Library General Public License,
     Version 2.0". 33 files have unknown license. Detailed output of
     licensecheck in /home/fedora/2281552-accessibility-inspector/srpm-
     unpacked/review-accessibility-inspector/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 2021 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not the first command in %prep.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: accessibility-inspector-24.05.0-1.fc41.aarch64.rpm
          accessibility-inspector-debuginfo-24.05.0-1.fc41.aarch64.rpm
          accessibility-inspector-debugsource-24.05.0-1.fc41.aarch64.rpm
          accessibility-inspector-24.05.0-1.fc41.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmporeh1_1b')]
checks: 32, packages: 4

accessibility-inspector.aarch64: W: no-manual-page-for-binary accessibilityinspector
accessibility-inspector.aarch64: W: files-duplicate /usr/share/licenses/accessibility-inspector/LGPL-3.0-or-later.txt /usr/share/licenses/accessibility-inspector/LGPL-3.0-only.txt
 4 packages and 0 specfiles checked; 0 errors, 2 warnings, 65 filtered, 0 badness; has taken 0.8 s 




Rpmlint (debuginfo)
-------------------
Checking: accessibility-inspector-debuginfo-24.05.0-1.fc41.aarch64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpy_1qj5ny')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 11 filtered, 0 badness; has taken 0.3 s 





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

accessibility-inspector.aarch64: W: no-manual-page-for-binary accessibilityinspector
accessibility-inspector.aarch64: W: files-duplicate /usr/share/licenses/accessibility-inspector/LGPL-3.0-or-later.txt /usr/share/licenses/accessibility-inspector/LGPL-3.0-only.txt
 3 packages and 0 specfiles checked; 0 errors, 2 warnings, 63 filtered, 0 badness; has taken 1.0 s 



Source checksums
----------------
https://kde.org/info/kde-gear-signing-keys.pgp :
  CHECKSUM(SHA256) this package     : 00bc4dd449f705b9d1c59b5e2737747cd840573a49cbe83e470f638bab167cb8
  CHECKSUM(SHA256) upstream package : 00bc4dd449f705b9d1c59b5e2737747cd840573a49cbe83e470f638bab167cb8
https://download.kde.org/stable/release-service/24.05.0/src/accessibility-inspector-24.05.0.tar.xz.sig :
  CHECKSUM(SHA256) this package     : d66363c525a7ceb7c3e9228af1dd28e09953651fa42f015fe7b8874897be41a0
  CHECKSUM(SHA256) upstream package : d66363c525a7ceb7c3e9228af1dd28e09953651fa42f015fe7b8874897be41a0
https://download.kde.org/stable/release-service/24.05.0/src/accessibility-inspector-24.05.0.tar.xz :
  CHECKSUM(SHA256) this package     : 6c8830aaadc610dd1412a4fe428d444c4e5a3f9fe4e1cd037ed9334f0646ea98
  CHECKSUM(SHA256) upstream package : 6c8830aaadc610dd1412a4fe428d444c4e5a3f9fe4e1cd037ed9334f0646ea98


Requires
--------
accessibility-inspector (rpmlib, GLIBC filtered):
    hicolor-icon-theme
    ld-linux-aarch64.so.1()(64bit)
    libKF6ConfigWidgets.so.6()(64bit)
    libKF6CoreAddons.so.6()(64bit)
    libKF6Crash.so.6()(64bit)
    libKF6DBusAddons.so.6()(64bit)
    libKF6I18n.so.6()(64bit)
    libKF6XmlGui.so.6()(64bit)
    libQt6Core.so.6()(64bit)
    libQt6Core.so.6(Qt_6)(64bit)
    libQt6Core.so.6(Qt_6.7)(64bit)
    libQt6Gui.so.6()(64bit)
    libQt6Gui.so.6(Qt_6)(64bit)
    libQt6Widgets.so.6()(64bit)
    libQt6Widgets.so.6(Qt_6)(64bit)
    libaccessibilityinspector.so.1()(64bit)
    libc.so.6()(64bit)
    libqaccessibilityclient-qt6.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    rtld(GNU_HASH)

accessibility-inspector-debuginfo (rpmlib, GLIBC filtered):

accessibility-inspector-debugsource (rpmlib, GLIBC filtered):



Provides
--------
accessibility-inspector:
    accessibility-inspector
    accessibility-inspector(aarch-64)
    application()
    application(org.kde.accessibilityinspector.desktop)
    libaccessibilityinspector.so.1()(64bit)
    metainfo()
    metainfo(org.kde.accessibilityinspector.metainfo.xml)

accessibility-inspector-debuginfo:
    accessibility-inspector-debuginfo
    accessibility-inspector-debuginfo(aarch-64)
    debuginfo(build-id)
    libaccessibilityinspector.so.1.0-24.05.0-1.fc41.aarch64.debug()(64bit)

accessibility-inspector-debugsource:
    accessibility-inspector-debugsource
    accessibility-inspector-debugsource(aarch-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -n accessibility-inspector
Buildroot used: fedora-rawhide-aarch64
Active plugins: Generic, C/C++, Shell-api
Disabled plugins: Java, R, fonts, Ocaml, Haskell, Python, SugarActivity, Perl, PHP
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) Had to change %{stable_kf6} to stable for review tool to work.
b) Please also check the signature.
Change
Source :        https://download.kde.org/%{stable_kf6}/release-service/%{version}/src/%{name}-%{version}.tar.xz
to
Source0:        https://download.kde.org/stable/release-service/%{version}/src/%{name}-%{version}.tar.xz
Source1:        https://download.kde.org/stable/release-service/%{version}/src/%{name}-%{version}.tar.xz.sig
Source2:        https://kde.org/info/kde-gear-signing-keys.pgp

change
# other dependencies
BuildRequires:  cmake(QAccessibilityClient6)
to
# other dependencies
BuildRequires:  cmake(QAccessibilityClient6)
BuildRequires:  gnupg2

and change
%autosetup
to
%autosetup
%{gpgverify} --keyring='%{SOURCE2}' --signature='%{SOURCE1}' --data='%{SOURCE0}'

%stable_kf6 is provided by kf6-rpm-macros, and the macro is necessary for KDE packages so that the proper directory tree is chosen; depending on the version, it's not always "stable".

KDE SIG's automation which handles the simultaneous updates of Gear releases (of which this will become a part) does not handle GPG verification, and therefore other KDE packages do not do this either.

Ok. Builds on Koji:
https://koji.fedoraproject.org/koji/taskinfo?taskID=118383738

Will see if can get GPG verification added to KDE SIG automation:
https://pagure.io/fedora-kde/SIG/issue/524

Approved.

The Pagure repository was created at https://src.fedoraproject.org/rpms/accessibility-inspector