Bug 228186

Summary: Review Request: gsm - Shared libraries for GSM speech compressor
Product: [Fedora] Fedora Reporter: John Guthrie <mathguthrie>
Component: Package ReviewAssignee: Dominik 'Rathann' Mierzejewski <dominik>
Status: CLOSED NOTABUG QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideFlags: dominik: fedora‑review-
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-05-10 17:58:38 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 201449, 239770    

Description John Guthrie 2007-02-10 23:49:03 EST
Spec URL: http://www.guthrie.info/RPMS/fc6/gsm.spec
SRPM URL: http://www.guthrie.info/RPMS/fc6/gsm-1.0.12-1.fc6.src.rpm
Description: Contains runtime shared libraries for libgsm, an implementation of
the European GSM 06.10 provisional standard for full-rate speech
transcoding, prI-ETS 300 036, which uses RPE/LTP (residual pulse
excitation/long term prediction) coding at 13 kbit/s.
Comment 1 Mamoru TASAKA 2007-02-10 23:55:17 EST
*** Bug 228185 has been marked as a duplicate of this bug. ***
Comment 2 Ville Skyttä 2007-02-11 03:46:04 EST
I suppose the reason this hasn't been in Fedora already earlier is patent
concerns on GSM 06.10 (see eg. the project homepage for more info) - I suppose
this requires an ack from legal before inclusion.
Comment 3 Michael Schwendt 2007-02-11 06:56:58 EST
Recycling an old comment:

[...]

Based on moderate Googling, there is no evidence of public patent
claims by Philips or any court cases specific to GSM 06.10
(they do hold patents > for much newer GSM technology). There's
only second hand knowledge which dates back as far as Nov 2000:
 
    http://www.mail-archive.com/ietf@ietf.org/msg03976.html

Jutta Deneger, one of the authors of the "gsm" package, also appears
in that thread and has still not been contacted by Philips while she
still offers the code on her home page. The patent analyzed in that
thread,
 
     http://www.freepatentsonline.com/4932061.html
 
expires in roughly more than one year. It is believed to not apply
to GSM 06.10.

[...]

Remember, libsndfile contains a copy of "gsm" and also is in Fedora.
The libsndfile author also is not aware of anything else than very
vague rumours and therefore is unconcerned. 
Comment 4 John Guthrie 2007-02-11 14:08:02 EST
I forgot to mention (although it might be clear from the .spec file) that this
RPM is based on a DAG RPM.  That may or may not help with patent issues.
Comment 5 Michael Schwendt 2007-04-08 08:04:50 EDT
"sox" in Core is built --with-gsm and contains a copy of gsm

"linphone" in Extras contains a copy of gsm-1.0.10

[...]

@ John:

* Files in gsm-devel are not writable by owner. chmod u+w needed

* Static library should be deleted from -devel, summary and
description.

* The patch is out-of-date and needs an update. It creates
libgsm.so.1.0.10 but this is libgsm.so.1.0.12.

Suggest you add a %check section that makes sure this doesn't
happen for future patch-levels.

--- gsm.spec.orig       2007-02-11 04:46:37.000000000 +0100
+++ gsm.spec    2007-04-08 14:06:13.000000000 +0200
@@ -45,6 +45,9 @@
 %{__ln_s} -f toast %{buildroot}%{_bindir}/untoast
 %{__ln_s} -f toast %{buildroot}%{_bindir}/tcat
 
+%check
+[ -f %{_libdir}/libgsm.so.%{version} ]
+
 %post -p /sbin/ldconfig
 
 %postun -p /sbin/ldconfig

* The %install section uses a few hardcoded paths that should be
replaced with macros.

* %mandir in %files section is %doc automatically.
Comment 6 Michael Schwendt 2007-04-08 08:20:59 EDT
Removing from FE-Legal tracker since this code is in the distribution
multiple times.
Comment 7 Peter Lemenkov 2007-04-11 15:14:54 EDT
John, please update ypur spec according to the latest proposals. Take a look at
Mattias's one here:

http://ftp.freshrpms.net/pub/freshrpms/fedora/linux/6/gsm/gsm-1.0.12-1.fc6.src.rpm
Comment 8 Peter Lemenkov 2007-04-11 15:15:46 EDT
(In reply to comment #7)
> Take a look at Mattias's one here:

Oops!

s/Mattias/Matthias/g
Comment 9 Michael Schwendt 2007-04-18 06:45:33 EDT
"ladspa-swh-plugins" in Extras contains a copy of gsm
Comment 10 Ville Skyttä 2007-04-18 10:49:17 EDT
xine-lib >= 1.1.5 in Extras contains one too.  (I looked into changing it to use
system libgsm, but some gsm's private things are being used so it doesn't look
like a no-brainer.)
Comment 11 Dominik 'Rathann' Mierzejewski 2007-04-28 10:14:45 EDT
Taking the review.
Comment 12 Dominik 'Rathann' Mierzejewski 2007-04-28 10:19:11 EDT
... after the proposed package has been updated according to the comments above.
Comment 13 Dominik 'Rathann' Mierzejewski 2007-04-30 10:35:33 EDT
Hm. It looks like the original submitter hasn't posted anything since February.
In that case, this will be closed and marked as FE-DEADREVIEW if the submitter
doesn't reply within a week.
Comment 14 Dominik 'Rathann' Mierzejewski 2007-05-10 17:58:38 EDT
Closing.