Bug 228186
Summary: | Review Request: gsm - Shared libraries for GSM speech compressor | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | John Guthrie <mathguthrie> |
Component: | Package Review | Assignee: | Dominik 'Rathann' Mierzejewski <dominik> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | dominik:
fedora-review-
|
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-05-10 21:58:38 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 201449, 239770 |
Description
John Guthrie
2007-02-11 04:49:03 UTC
*** Bug 228185 has been marked as a duplicate of this bug. *** I suppose the reason this hasn't been in Fedora already earlier is patent concerns on GSM 06.10 (see eg. the project homepage for more info) - I suppose this requires an ack from legal before inclusion. Recycling an old comment: [...] Based on moderate Googling, there is no evidence of public patent claims by Philips or any court cases specific to GSM 06.10 (they do hold patents > for much newer GSM technology). There's only second hand knowledge which dates back as far as Nov 2000: http://www.mail-archive.com/ietf@ietf.org/msg03976.html Jutta Deneger, one of the authors of the "gsm" package, also appears in that thread and has still not been contacted by Philips while she still offers the code on her home page. The patent analyzed in that thread, http://www.freepatentsonline.com/4932061.html expires in roughly more than one year. It is believed to not apply to GSM 06.10. [...] Remember, libsndfile contains a copy of "gsm" and also is in Fedora. The libsndfile author also is not aware of anything else than very vague rumours and therefore is unconcerned. I forgot to mention (although it might be clear from the .spec file) that this RPM is based on a DAG RPM. That may or may not help with patent issues. "sox" in Core is built --with-gsm and contains a copy of gsm "linphone" in Extras contains a copy of gsm-1.0.10 [...] @ John: * Files in gsm-devel are not writable by owner. chmod u+w needed * Static library should be deleted from -devel, summary and description. * The patch is out-of-date and needs an update. It creates libgsm.so.1.0.10 but this is libgsm.so.1.0.12. Suggest you add a %check section that makes sure this doesn't happen for future patch-levels. --- gsm.spec.orig 2007-02-11 04:46:37.000000000 +0100 +++ gsm.spec 2007-04-08 14:06:13.000000000 +0200 @@ -45,6 +45,9 @@ %{__ln_s} -f toast %{buildroot}%{_bindir}/untoast %{__ln_s} -f toast %{buildroot}%{_bindir}/tcat +%check +[ -f %{_libdir}/libgsm.so.%{version} ] + %post -p /sbin/ldconfig %postun -p /sbin/ldconfig * The %install section uses a few hardcoded paths that should be replaced with macros. * %mandir in %files section is %doc automatically. Removing from FE-Legal tracker since this code is in the distribution multiple times. John, please update ypur spec according to the latest proposals. Take a look at Mattias's one here: http://ftp.freshrpms.net/pub/freshrpms/fedora/linux/6/gsm/gsm-1.0.12-1.fc6.src.rpm (In reply to comment #7) > Take a look at Mattias's one here: Oops! s/Mattias/Matthias/g "ladspa-swh-plugins" in Extras contains a copy of gsm xine-lib >= 1.1.5 in Extras contains one too. (I looked into changing it to use system libgsm, but some gsm's private things are being used so it doesn't look like a no-brainer.) Taking the review. ... after the proposed package has been updated according to the comments above. Hm. It looks like the original submitter hasn't posted anything since February. In that case, this will be closed and marked as FE-DEADREVIEW if the submitter doesn't reply within a week. Closing. |