Bug 2282872
| Summary: | Review Request: supernovas-libs - SuperNOVAS astrometry library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Attila Kovacs <attipaci> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | mattia.verga, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://smithsonian.github.io/SuperNOVAS/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-05-24 09:11:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Attila Kovacs
2024-05-23 09:00:23 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7479633 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2282872-supernovas-libs/fedora-rawhide-x86_64/07479633-supernovas-libs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://download.copr.fedorainfracloud.org/results/attipaci/supernovas/fedora-rawhide-x86_64/07479706-supernovas-libs/supernovas-libs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/attipaci/supernovas/fedora-rawhide-x86_64/07479706-supernovas-libs/supernovas-libs-1.0.1-1.fc41.src.rpm - Parallel make with `%{?_smp_mflags}` macro. - Removed superfluous `%clean` section. -- Attila. Created attachment 2034791 [details]
The .spec file difference from Copr build 7479633 to 7480089
Copr build: https://copr.fedorainfracloud.org/coprs/build/7480089 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2282872-supernovas-libs/fedora-rawhide-x86_64/07480089-supernovas-libs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://download.copr.fedorainfracloud.org/results/attipaci/supernovas/fedora-rawhide-x86_64/07480106-supernovas-libs/supernovas-libs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/attipaci/supernovas/fedora-rawhide-x86_64/07480106-supernovas-libs/supernovas-libs-1.0.1-1.fc41.src.rpm - Removed `%{version}` macro from comments (rpmlint warnings) -- Attila. Created attachment 2034795 [details]
The .spec file difference from Copr build 7480089 to 7480129
Copr build: https://copr.fedorainfracloud.org/coprs/build/7480129 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2282872-supernovas-libs/fedora-rawhide-x86_64/07480129-supernovas-libs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://download.copr.fedorainfracloud.org/results/attipaci/supernovas/fedora-rawhide-aarch64/07481514-supernovas-libs/supernovas-libs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/attipaci/supernovas/fedora-rawhide-aarch64/07481514-supernovas-libs/supernovas-libs-1.0.1-1.fc41.src.rpm - Changed `SONAME` to carry major version only (also for upcoming releases upstream) -- in line with the expectation to remain ABI back-compatible through all releases with the same major version. -- Attila. Created attachment 2034803 [details]
The .spec file difference from Copr build 7480129 to 7481536
Copr build: https://copr.fedorainfracloud.org/coprs/build/7481536 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2282872-supernovas-libs/fedora-rawhide-x86_64/07481536-supernovas-libs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://download.copr.fedorainfracloud.org/results/attipaci/supernovas/fedora-rawhide-x86_64/07481595-supernovas-libs/supernovas-libs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/attipaci/supernovas/fedora-rawhide-x86_64/07481595-supernovas-libs/supernovas-libs-1.0.1-1.fc41.src.rpm - Partial reversion of the last change. Back to full version in .so file name (e.g. 'libsupernovas.so.1.0.1'), and major-only SONAME (e.g. 'libsupernovas.so.1'). If my understanding of the packaging guide is correct, this is best practice for libs. But do let me know if a different scheme is recommended for versioning these. -- Attila Created attachment 2034820 [details]
The .spec file difference from Copr build 7481536 to 7481623
Copr build: https://copr.fedorainfracloud.org/coprs/build/7481623 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2282872-supernovas-libs/fedora-rawhide-x86_64/07481623-supernovas-libs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. It is not needed to package the -libs, -devel and -docs separately. You should use just one main source package and use subpackages. For example look at https://src.fedoraproject.org/rpms/wcstools/blob/rawhide/f/wcstools.spec Usually you should name the source package just as upstream (supernovas) and then provide the subpackages. In your case I think you can avoid the -libs subpackage and just use the main supernova package for that. Also, have a look at https://docs.fedoraproject.org/en-US/packaging-guidelines/ there are some things to tweak (for example, you're missing BuildRequires: make and you should not use rm -rf %{buildroot} ) (In reply to Mattia Verga from comment #14) Hi Mattia! Thanks for the tip. :-) I definitely prefer to have one .spec to build all three packages from the same source. I'll merge the separate .spec files as per you described. I assume you'll want a separate review request then since the package name will be different from that of this sub-package. (Or let me know if you prefer to continue here instead.) I'll try to get the merging done tomorrow. cheers, -- Attila (In reply to Attila Kovacs from comment #15) > (In reply to Mattia Verga from comment #14) > > > Hi Mattia! > > Thanks for the tip. :-) I definitely prefer to have one .spec to build all > three packages from the same source. I'll merge the separate .spec files as > per you described. I assume you'll want a separate review request then since > the package name will be different from that of this sub-package. (Or let me > know if you prefer to continue here instead.) > It's fine to rename the .spec and .src files and change the title here, but if you prefer you can of course submit a new review request and close this one too ;-) *** This bug has been marked as a duplicate of bug 2283055 *** |