Bug 2282977
| Summary: | Review Request: rust-range_map_vec - Implementation of a range map data structure backed by a Vec | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Oliver Steffen <osteffen> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | berrange, crobinso, decathorpe, kraxel, osteffen, package-review, rjones, zbyszek | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://crates.io/crates/range_map_vec | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-07-10 11:26:29 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Oliver Steffen
2024-05-23 13:36:26 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7481364 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2282977-rust-range_map_vec/fedora-rawhide-x86_64/07481364-rust-range_map_vec/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Just to make sure - version 0.2.0 has been released last night - I assume you specifically need v0.1 for now? Other than that, package looks like 100% boilerplate without modifications, so should be good to go. This crate is needed for the IGVM crate, which has already picked that up: https://github.com/microsoft/igvm/commit/5ef0d428c34c5359d06ce91f12aca71fe4b3e890 Let me update: Spec URL: https://osteffen.fedorapeople.org/packages/rust-range_map_vec/rust-range_map_vec.spec SRPM URL: https://osteffen.fedorapeople.org/packages/rust-range_map_vec/rust-range_map_vec-0.2.0-1.fc41.src.rpm Created attachment 2035298 [details]
The .spec file difference from Copr build 7481364 to 7495271
Copr build: https://copr.fedorainfracloud.org/coprs/build/7495271 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2282977-rust-range_map_vec/fedora-rawhide-x86_64/07495271-rust-range_map_vec/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thank you for the update! Package looks good to me. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === I can help you with importing and some Rust SIG specific stuff as soon as you have found a sponsor, just let me know. > I can help you with importing and some Rust SIG specific stuff as soon as you have found a sponsor, just let me know.
I have now sponsored Oliver for membership of the packager group
Great! removing FE-NEEDSPONSOR. Looks like this was never imported. Are you still interested in this package? The "fedora-review+" flag will likely time out (if it hasn't already). Please let me know if I need to refresh the flag. (In reply to Fabio Valentini from comment #9) > Looks like this was never imported. Are you still interested in this package? > The "fedora-review+" flag will likely time out (if it hasn't already). > Please let me know if I need to refresh the flag. This is still desired as a dep for SVSM, but Oliver has been offline since just after this was approved. Hopefully we'll get it imported in the coming week. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-range_map_vec Imported the package. Thanks! FEDORA-2024-77344862d3 (rust-range_map_vec-0.2.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-77344862d3 FEDORA-2024-77344862d3 (rust-range_map_vec-0.2.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |