Red Hat Bugzilla – Full Text Bug Listing
|Summary:||Review Request: python-nevow - Web application construction kit written in Python|
|Product:||[Fedora] Fedora||Reporter:||Matthias Saou <matthias>|
|Component:||Package Review||Assignee:||Xavier Lamien <lxtnow>|
|Status:||CLOSED NEXTRELEASE||QA Contact:||Fedora Package Reviews List <fedora-package-review>|
|Fixed In Version:||Doc Type:||Bug Fix|
|Doc Text:||Story Points:||---|
|Last Closed:||2007-04-20 06:53:11 EDT||Type:||---|
|oVirt Team:||---||RHEL 7.3 requirements from Atomic Host:|
|Bug Depends On:|
Description Matthias Saou 2007-02-12 11:13:49 EST
Spec URL: http://ftp.es6.freshrpms.net/tmp/extras/python-nevow/ SRPM URL: http://ftp.es6.freshrpms.net/tmp/extras/python-nevow/ Description: Nevow (pronounced as the French "nouveau", or "noo-voh") is a web application construction kit written in Python. It is designed to allow the programmer to express as much of the view logic as desired in Python.
Comment 1 Xavier Lamien 2007-04-05 22:14:20 EDT
Well, OK - Mock Build on FC-6 and FC-Devel (i386) OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License is MIT OK - License text is included in package. OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 4c744ea416b36dc9067b67e18c5707b5 Nevow-0.9.0.tar.gz OK - Package has correct buildroot. OK - BuildRequires isn't redundant. ?? - %prep stage SHOULD be quiet by setting -q option. OK - %build and %install stages is correct and work. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package is code or permissible content. OK - %doc files don't affect runtime. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Changelog section is correct. -------------------------------------- - rpmlint output isn't silent: ------------------------------------- * From .rpm file: W: python-nevow wrong-file-end-of-line-encoding /usr/share/doc/python-nevow-0.9.0/examples/blogengine/styles/typo.css W: python-nevow wrong-file-end-of-line-encoding /usr/share/doc/python-nevow-0.9.0/examples/blogengine/styles/form.css E: python-nevow zero-length /usr/lib/python2.4/site-packages/nevow/test/test_package/Foo/Baz/Quux.js E: python-nevow non-executable-script /usr/lib/python2.4/site-packages/nevow/test/test_object.js 0644 W: python-nevow wrong-file-end-of-line-encoding /usr/share/doc/python-nevow-0.9.0/examples/postit/styles/typo.css W: python-nevow wrong-file-end-of-line-encoding /usr/share/doc/python-nevow-0.9.0/examples/postit/postit.html E: python-nevow zero-length /usr/lib/python2.4/site-packages/nevow/test/test_package/Foo/Bar.js W: python-nevow wrong-file-end-of-line-encoding /usr/share/doc/python-nevow-0.9.0/examples/postit/atom.xml W: python-nevow wrong-file-end-of-line-encoding /usr/share/doc/python-nevow-0.9.0/examples/postit/styles/postit.css E: python-nevow zero-length /usr/lib/python2.4/site-packages/nevow/empty.js W: python-nevow wrong-file-end-of-line-encoding /usr/share/doc/python-nevow-0.9.0/examples/blogengine/atom.xml W: python-nevow wrong-file-end-of-line-encoding /usr/share/doc/python-nevow-0.9.0/examples/blogengine/styles/site.css W: python-nevow doc-file-dependency /usr/share/doc/python-nevow-0.9.0/examples/i18n/update-l10n /bin/sh * From .srpm file : E: python-nevow unknown-key GPG#e42d547b W: python-nevow setup-not-quiet SHOULD be fix
Comment 2 Matthias Saou 2007-04-10 07:52:51 EDT
You seem to have reviewed the 0.9.0 package, while a 0.9.18-1 package has been available for weeks now... I'll fix the EOL encoding issues, but the empty js files will certainly stay... those are just examples after all.
Comment 3 Matthias Saou 2007-04-10 08:08:57 EDT
http://ftp.es6.freshrpms.net/tmp/extras/python-nevow/python-nevow-0.9.18-2.src.rpm * Tue Apr 10 2007 Matthias Saou <http://freshrpms.net/> 0.9.18-2 - Fix some end-of-line encodings and executable bits in the docs. * Fri Mar 23 2007 Matthias Saou <http://freshrpms.net/> 0.9.18-1 - Update to 0.9.18.
Comment 4 Xavier Lamien 2007-04-10 20:24:21 EDT
Sorry for the late, <in reply to comment #2> indeed, i will check it out ;-)
Comment 5 Matthias Saou 2007-04-16 07:33:48 EDT
Ping? Please review the 0.9.18 packages ASAP, thanks.
Comment 6 Xavier Lamien 2007-04-17 10:37:10 EDT
(In reply to comment #5) > Ping? Please review the 0.9.18 packages ASAP, thanks. checked out. sorry for the late. the updated srpm is silent, but not the rpm, it seems still have wrong-line-ending. you can fix these with sed ;-)
Comment 7 Xavier Lamien 2007-04-17 10:40:36 EDT
> I'll fix the EOL encoding issues, but the empty js files will certainly stay... > those are just examples after all. yep, this error can be ignored from rpmlint.
Comment 8 Matthias Saou 2007-04-18 05:50:11 EDT
I'm not seeing any more EOL encoding issues. Are you sure you reviewed the 0.9.18-2 package and not the 0.9.18-1 one? Could you copy/paste your rpmlint output so that I know for which files it is? All I get is this : E: python-nevow zero-length /usr/lib/python2.4/site-packages/nevow/test/test_package/Foo/Baz/Quux.js E: python-nevow zero-length /usr/lib/python2.4/site-packages/nevow/test/test_package/Foo/Bar.js Which are both harmless, and removing those files could only mean breaking some tests.
Comment 9 Xavier Lamien 2007-04-18 07:59:25 EDT
Sorry, my rpmlint was broken, it gave me the same errors on both packages. Things fixed now. ---------- OK - rpmlint is silent from SRPM file. OK - rpmlint from RPM file: E: python-nevow zero-length /usr/lib/python2.4/site-packages/nevow/test/test_package/Foo/Baz/Quux.js E: python-nevow zero-length /usr/lib/python2.4/site-packages/nevow/test/test_package/Foo/Bar.js These are not a blocker and can be ignored. ----------- APPROUVED -----------