Bug 2283042

Summary: Review Request: rust-pear_codegen - (codegen) pear is a fruit
Product: [Fedora] Fedora Reporter: wojnilowicz <lukasz.wojnilowicz>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: eclipseo: fedora-review+
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/pear_codegen
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-06-02 08:35:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description wojnilowicz 2024-05-23 18:10:01 UTC 
Spec URL: https://wojnilowicz.fedorapeople.org/rust-pear_codegen.spec
SRPM URL: https://wojnilowicz.fedorapeople.org/rust-pear_codegen-0.2.9-1.fc39.src.rpm

rust2rpm.toml: https://wojnilowicz.fedorapeople.org/pear_codegen/rust2rpm.toml

Description:
(codegen) pear is a fruit

Fedora Account System Username: wojnilowicz

I plan on packaging https://github.com/ActivityWatch/aw-server-rust and pear_codegen package is in its requirements chain. The chain is as follows: aw-server-rust->rocket->rocket_http->pear->pear_codegen.
Comment 1 Fedora Review Service 2024-05-23 18:18:49 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7482517
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283042-rust-pear_codegen/fedora-rawhide-x86_64/07482517-rust-pear_codegen/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 2 Robert-André Mauchin 🐧 2024-06-01 14:38:19 UTC 
This package was generated using rust2rpm, which simplifies the review.
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

    [x] The latest version is packaged or packaging an earlier version is justified.
    [x] The License tag reflects the package contents and uses the correct identifiers.
    [x] The package builds successfully in mock.
    [x] Package is installable (checked by fedora-review).
    [x] There are no relevant rpmlint errors.
    [x] The package runs tests in %check.
    [-] The package's binaries don't conflict with binaries already in the distribution.
    [-] There are no %{_bindir}/* wildcards in %files.
    [x] The package complies with the Rust and general Packaging Guidelines.

Package approved!

On import, don't forget to do the following:

    [ ] Add the package to release-monitoring.org
    [ ] Give rust-sig privileges (at least commit) on the package
    [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
Comment 3 Fedora Admin user for bugzilla script actions 2024-06-02 08:21:15 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pear_codegen
Comment 4 Fedora Update System 2024-06-02 08:33:28 UTC 
FEDORA-2024-4373cff4c7 (rust-pear_codegen-0.2.9-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-4373cff4c7
Comment 5 Fedora Update System 2024-06-02 08:35:21 UTC 
FEDORA-2024-4373cff4c7 (rust-pear_codegen-0.2.9-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 6 wojnilowicz 2024-06-02 08:56:25 UTC 
Everything's done. Thanks for the review!