Bug 2283342

Summary:	Review Request: mingw-objfw - MinGW port of ObjFW
Product:	[Fedora] Fedora	Reporter:	Jonathan S. <js-fedora>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-11-24 07:18:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jonathan S. 2024-05-27 00:30:09 UTC

Spec URL: https://nil.im/tmp/mingw-objfw.spec
SRPM URL: https://nil.im/tmp/mingw-objfw-1.1.4-1.fc40.src.rpm
Description: MinGW port of ObjFW
Fedora Account System Username: js
Successful Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=118133335

ObjFW is a portable, lightweight framework for the Objective-C language. It
enables you to write an application in Objective-C that will run on any
platform supported by ObjFW without having to worry about differences between
operating systems or various frameworks you would otherwise need if you want to
be portable.

It supports all modern Objective-C features when using Clang, but is also
compatible with GCC ≥ 4.6 to allow maximum portability.

ObjFW also comes with its own lightweight and extremely fast Objective-C
runtime, which in real world use cases was found to be significantly faster
than both GNU's and Apple's runtime.

Comment 1 Neal Gompa 2024-05-27 00:31:08 UTC

Taking this review.

Comment 2 Neal Gompa 2024-05-28 17:39:34 UTC

Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled and recorded
* No relevant serious issues from rpmlint

Note: fedora-review and rpmlint aren't very happy with this package because mingw-* packages have a somewhat unusual layout compared to native packages. I skipped over those.

PACKAGE APPROVED.

Comment 3 Neal Gompa 2024-05-28 17:44:01 UTC

Oh one thing to fix on import: please add "%license" lines to all subpackage file lists, since these packages are independent.

Comment 4 Fedora Admin user for bugzilla script actions 2024-06-01 12:07:02 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-objfw

Comment 5 Jonathan S. 2024-06-01 12:12:47 UTC

(In reply to Neal Gompa from comment #3)
> Oh one thing to fix on import: please add "%license" lines to all subpackage
> file lists, since these packages are independent.

Ah, thanks! That was by accident. Fixed on import.

Comment 6 Elliott Sales de Andrade 2024-11-24 07:18:39 UTC

Please close your review bugs once they've been imported.