I have a hacky patch that gets this to build, but
a) I can't figure out what announced change in Python 3.13 causes this behavior (pickle.{Pickler,Unpickler} methods not being overrideable without subclassing)
b) this leaks new class definitions (which I indicate are not meant to be public by underscores, but still) so probably should not be merged as is, but should be reported upstream by one of the package maintainers
https://src.fedoraproject.org/rpms/python-rdflib/pull-request/5
Comment 3Robert-André Mauchin 🐧
2024-06-13 19:47:48 UTC
python-rdflib fails to build with Python 3.13.0b1. __________________ TestUtil.test_to_bits_from_bits_round_trip __________________ self = <test_nodepickler.TestUtil object at 0x7f5277295810> def test_to_bits_from_bits_round_trip(self): np = NodePickler() a = Literal( """A test with a \\n (backslash n), "\u00a9" , and newline \n and a second line. """ ) > b = np.loads(np.dumps(a)) test/test_store/test_nodepickler.py:32: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = <rdflib.store.NodePickler object at 0x7f52751b1fd0> obj = rdflib.term.Literal('A test with a \\n (backslash n), "©" , and newline \n and a second line.\n') protocol = None, bin = None def dumps( self, obj: "Node", protocol: Optional[Any] = None, bin: Optional[Any] = None ): src = BytesIO() p = Pickler(src) # NOTE on type error: https://github.com/python/mypy/issues/2427 # type error: Cannot assign to a method > p.persistent_id = self._get_ids # type: ignore[assignment] E AttributeError: '_pickle.Pickler' object attribute 'persistent_id' is read-only rdflib/store.py:149: AttributeError _________________________ TestUtil.test_literal_cases __________________________ self = <test_nodepickler.TestUtil object at 0x7f5277295950> def test_literal_cases(self): np = NodePickler() for l in cases: a = Literal(l) > b = np.loads(np.dumps(a)) test/test_store/test_nodepickler.py:40: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = <rdflib.store.NodePickler object at 0x7f5273890a50> obj = rdflib.term.Literal('no quotes'), protocol = None, bin = None def dumps( self, obj: "Node", protocol: Optional[Any] = None, bin: Optional[Any] = None ): src = BytesIO() p = Pickler(src) # NOTE on type error: https://github.com/python/mypy/issues/2427 # type error: Cannot assign to a method > p.persistent_id = self._get_ids # type: ignore[assignment] E AttributeError: '_pickle.Pickler' object attribute 'persistent_id' is read-only FAILED test/test_store/test_nodepickler.py::TestUtil::test_to_bits_from_bits_round_trip FAILED test/test_store/test_nodepickler.py::TestUtil::test_literal_cases - At... https://docs.python.org/3.13/whatsnew/3.13.html For the build logs, see: https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/07495797-python-rdflib/ For all our attempts to build python-rdflib with Python 3.13, see: https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/python-rdflib/ Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.13: https://copr.fedorainfracloud.org/coprs/g/python/python3.13/ Let us know here if you have any questions. Python 3.13 is planned to be included in Fedora 41. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13. A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon. We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.