Bug 2283621

Summary: [UI][Provider mode] Remove Client related resources available for Clients with stable heartbeat
Product: [Red Hat Storage] Red Hat OpenShift Data Foundation Reporter: Daniel Osypenko <dosypenk>
Component: management-consoleAssignee: Bipul Adhikari <badhikar>
Status: CLOSED ERRATA QA Contact: Daniel Osypenko <dosypenk>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 4.16CC: badhikar, lgangava, muagarwa, nberry, nthomas, odf-bz-bot, omitrani
Target Milestone: ---   
Target Release: ODF 4.16.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: isf-provider
Fixed In Version: 4.16.0-124 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-07-17 13:23:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
fixed, remove btn disabled for stable clients none

Description Daniel Osypenko 2024-05-28 09:43:02 UTC
Created attachment 2035434 [details]
Storage Client web page

Created attachment 2035434 [details]
Storage Client web page

Description of problem (please be detailed as possible and provide log
snippests):

Remove client related resources available for clusters with stable heartbeat. 
The trash-icon should be grayed out showing that client delete is unavailable. 
Following the discussion on Jira story https://issues.redhat.com/browse/RHSTOR-5612?focusedId=24806238&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-24806238, the user should not be able to delete client from UI if 5 min timeout from the last heartbeat was not violated.  

Version of all relevant components (if applicable):
OCP 4.16.0-ec.6
ODF 4.16.0-108

Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?
may have effect

Is there any workaround available to the best of your knowledge?
not clicking on icon

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
1

Can this issue reproducible?
yes

Can this issue reproduce from the UI?


If this is a regression, please provide more details to justify this:


Steps to Reproduce:
1. Login to Provider cluster, navigate to Storage/Storage Clients, make sure you have hosted client clusters connected
2. Remove any client with last heartbeat > 5 min
3. 


Actual results:
user is able to delete cluster

Expected results:
user is not able to delete cluster, icon should be grayed out, tooltip should explain the 5-min rule

Additional info:

Comment 3 Nishanth Thomas 2024-05-28 12:41:29 UTC
Moving out of 4.17 as its not a blocker

Comment 4 Leela Venkaiah Gangavarapu 2024-05-29 11:18:08 UTC
Nishanth,

I believe this should be fixed at the earliest, as per the designs, even though the icon is visible, it should be disabled/greyed out when last heartbeat is less then 5 min old. Having this always enabled makes way for a destructive operation which should not be allowed.

To expand a bit on the technical details, the code backing this button invokes a force deletion of entire storage corresponding to a particular client which is detrimental for a connected & healthy client.

Daniel,

Please re-asses the release version and blocker status of this BZ.

thanks.

Comment 5 Ohad 2024-05-29 11:43:53 UTC
I agree with Leela, this should be a 4.16 blocker.
It allows, and enables, a user to delete an active system without the safeguards. This can and will lead to unrecoverable data loss as with this operation we are purging the data itself not just the k8s resources.

My perspective is that this is a risk we should not take.

Comment 7 Bipul Adhikari 2024-06-03 13:24:58 UTC
Yes we should fix this in ODF 4.16.

Comment 8 Sunil Kumar Acharya 2024-06-06 07:34:46 UTC
Please update the RDT flag/text appropriately.

Comment 9 Daniel Osypenko 2024-06-10 12:14:13 UTC
removed one Storage client from the Provider, the client had a Last heartbeat 0min.
ODF version is 4.16.0-118 on both Provider and Client (both provider and client were updated from 4.16.0-108).
The management-console of the Provider allowed me to remove the client.
screen recording - https://drive.google.com/file/d/1PcmWJDKi-0ou6e6DDxIE1cbz8MN8DGcx/view?usp=sharing

Comment 10 Bipul Adhikari 2024-06-10 15:22:30 UTC
as mentioned by the CI the fix is in the version 4.16.0-118 and not 108 please retry,

Comment 11 Bipul Adhikari 2024-06-10 15:53:38 UTC
I tested with 118 and indeed the issues have not been fixed there. Looks like it picked up wrong. I can see that the issue has been fixed in version 124. PTAL

Comment 12 Daniel Osypenko 2024-06-10 16:30:18 UTC
Created attachment 2036929 [details]
fixed, remove btn disabled for stable clients

Comment 13 Daniel Osypenko 2024-06-10 16:31:06 UTC
version fix 4.16.0-124

Comment 14 Sunil Kumar Acharya 2024-06-18 06:45:26 UTC
Please update the RDT flag/text appropriately.

Comment 16 errata-xmlrpc 2024-07-17 13:23:48 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Red Hat OpenShift Data Foundation 4.16.0 security, enhancement & bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:4591

Comment 17 Red Hat Bugzilla 2024-11-15 04:25:43 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days