Bug 2283710
| Summary: | Review Request: adwaita-icon-theme-legacy - Full-color icons for the Adwaita icon theme | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Neal Gompa <ngompa13> |
| Component: | Package Review | Assignee: | Jonathan Wright <jonathan> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jonathan, package-review |
| Target Milestone: | --- | Flags: | jonathan:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-05-31 01:16:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Neal Gompa
2024-05-28 23:25:46 UTC
Are all the .placeholder and .empty files really needed? (In reply to Jonathan Wright from comment #1) > Are all the .placeholder and .empty files really needed? Probably not, they're needed in git but not necessarily on install. I've updated the files in place to delete them. APPROVED
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: adwaita-icon-theme-legacy-46.2-1.fc41.noarch.rpm
adwaita-icon-theme-legacy-devel-46.2-1.fc41.noarch.rpm
adwaita-icon-theme-legacy-46.2-1.fc41.src.rpm
=================================================================== rpmlint session starts ==================================================================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpa8a87rzm')]
checks: 32, packages: 3
adwaita-icon-theme-legacy.noarch: W: no-documentation
adwaita-icon-theme-legacy-devel.noarch: W: no-documentation
adwaita-icon-theme-legacy.noarch: W: hidden-file-or-dir /usr/share/icons/AdwaitaLegacy/.icon-theme.cache
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/16x16/legacy/go-last.png /usr/share/icons/AdwaitaLegacy/16x16/legacy/go-first-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/16x16/legacy/go-last-rtl.png /usr/share/icons/AdwaitaLegacy/16x16/legacy/go-first.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/16x16/legacy/go-previous.png /usr/share/icons/AdwaitaLegacy/16x16/legacy/go-next-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/16x16/legacy/go-previous-rtl.png /usr/share/icons/AdwaitaLegacy/16x16/legacy/go-next.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/22x22/legacy/go-last.png /usr/share/icons/AdwaitaLegacy/22x22/legacy/go-first-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/22x22/legacy/go-last-rtl.png /usr/share/icons/AdwaitaLegacy/22x22/legacy/go-first.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/22x22/legacy/go-previous.png /usr/share/icons/AdwaitaLegacy/22x22/legacy/go-next-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/22x22/legacy/go-previous-rtl.png /usr/share/icons/AdwaitaLegacy/22x22/legacy/go-next.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/22x22/places/folder.png /usr/share/icons/AdwaitaLegacy/22x22/mimetypes/inode-directory.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/24x24/legacy/go-last.png /usr/share/icons/AdwaitaLegacy/24x24/legacy/go-first-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/24x24/legacy/go-last-rtl.png /usr/share/icons/AdwaitaLegacy/24x24/legacy/go-first.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/24x24/legacy/go-previous.png /usr/share/icons/AdwaitaLegacy/24x24/legacy/go-next-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/24x24/legacy/go-previous-rtl.png /usr/share/icons/AdwaitaLegacy/24x24/legacy/go-next.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/24x24/places/folder.png /usr/share/icons/AdwaitaLegacy/24x24/mimetypes/inode-directory.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/32x32/legacy/go-last.png /usr/share/icons/AdwaitaLegacy/32x32/legacy/go-first-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/32x32/legacy/go-last-rtl.png /usr/share/icons/AdwaitaLegacy/32x32/legacy/go-first.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/32x32/legacy/go-previous.png /usr/share/icons/AdwaitaLegacy/32x32/legacy/go-next-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/32x32/legacy/go-previous-rtl.png /usr/share/icons/AdwaitaLegacy/32x32/legacy/go-next.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/32x32/places/folder.png /usr/share/icons/AdwaitaLegacy/32x32/mimetypes/inode-directory.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/48x48/legacy/go-last.png /usr/share/icons/AdwaitaLegacy/48x48/legacy/go-first-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/48x48/legacy/go-last-rtl.png /usr/share/icons/AdwaitaLegacy/48x48/legacy/go-first.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/48x48/legacy/go-previous.png /usr/share/icons/AdwaitaLegacy/48x48/legacy/go-next-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/48x48/legacy/go-previous-rtl.png /usr/share/icons/AdwaitaLegacy/48x48/legacy/go-next.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/48x48/places/folder.png /usr/share/icons/AdwaitaLegacy/48x48/mimetypes/inode-directory.png
============================= 3 packages and 0 specfiles checked; 0 errors, 27 warnings, 13 filtered, 0 badness; has taken 0.3 s ============================
Rpmlint (installed packages)
----------------------------
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2
adwaita-icon-theme-legacy.noarch: W: no-documentation
adwaita-icon-theme-legacy-devel.noarch: W: no-documentation
adwaita-icon-theme-legacy.noarch: W: hidden-file-or-dir /usr/share/icons/AdwaitaLegacy/.icon-theme.cache
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/16x16/legacy/go-last.png /usr/share/icons/AdwaitaLegacy/16x16/legacy/go-first-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/16x16/legacy/go-last-rtl.png /usr/share/icons/AdwaitaLegacy/16x16/legacy/go-first.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/16x16/legacy/go-previous.png /usr/share/icons/AdwaitaLegacy/16x16/legacy/go-next-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/16x16/legacy/go-previous-rtl.png /usr/share/icons/AdwaitaLegacy/16x16/legacy/go-next.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/22x22/legacy/go-last.png /usr/share/icons/AdwaitaLegacy/22x22/legacy/go-first-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/22x22/legacy/go-last-rtl.png /usr/share/icons/AdwaitaLegacy/22x22/legacy/go-first.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/22x22/legacy/go-previous.png /usr/share/icons/AdwaitaLegacy/22x22/legacy/go-next-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/22x22/legacy/go-previous-rtl.png /usr/share/icons/AdwaitaLegacy/22x22/legacy/go-next.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/22x22/places/folder.png /usr/share/icons/AdwaitaLegacy/22x22/mimetypes/inode-directory.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/24x24/legacy/go-last.png /usr/share/icons/AdwaitaLegacy/24x24/legacy/go-first-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/24x24/legacy/go-last-rtl.png /usr/share/icons/AdwaitaLegacy/24x24/legacy/go-first.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/24x24/legacy/go-previous.png /usr/share/icons/AdwaitaLegacy/24x24/legacy/go-next-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/24x24/legacy/go-previous-rtl.png /usr/share/icons/AdwaitaLegacy/24x24/legacy/go-next.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/24x24/places/folder.png /usr/share/icons/AdwaitaLegacy/24x24/mimetypes/inode-directory.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/32x32/legacy/go-last.png /usr/share/icons/AdwaitaLegacy/32x32/legacy/go-first-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/32x32/legacy/go-last-rtl.png /usr/share/icons/AdwaitaLegacy/32x32/legacy/go-first.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/32x32/legacy/go-previous.png /usr/share/icons/AdwaitaLegacy/32x32/legacy/go-next-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/32x32/legacy/go-previous-rtl.png /usr/share/icons/AdwaitaLegacy/32x32/legacy/go-next.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/32x32/places/folder.png /usr/share/icons/AdwaitaLegacy/32x32/mimetypes/inode-directory.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/48x48/legacy/go-last.png /usr/share/icons/AdwaitaLegacy/48x48/legacy/go-first-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/48x48/legacy/go-last-rtl.png /usr/share/icons/AdwaitaLegacy/48x48/legacy/go-first.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/48x48/legacy/go-previous.png /usr/share/icons/AdwaitaLegacy/48x48/legacy/go-next-rtl.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/48x48/legacy/go-previous-rtl.png /usr/share/icons/AdwaitaLegacy/48x48/legacy/go-next.png
adwaita-icon-theme-legacy.noarch: W: files-duplicate /usr/share/icons/AdwaitaLegacy/48x48/places/folder.png /usr/share/icons/AdwaitaLegacy/48x48/mimetypes/inode-directory.png
2 packages and 0 specfiles checked; 0 errors, 27 warnings, 9 filtered, 0 badness; has taken 0.2 s
Source checksums
----------------
https://download.gnome.org/sources/adwaita-icon-theme-legacy/46/adwaita-icon-theme-legacy-46.2.tar.xz :
CHECKSUM(SHA256) this package : 548480f58589a54b72d18833b755b15ffbd567e3187249d74e2e1f8f99f22fb4
CHECKSUM(SHA256) upstream package : 548480f58589a54b72d18833b755b15ffbd567e3187249d74e2e1f8f99f22fb4
Requires
--------
adwaita-icon-theme-legacy (rpmlib, GLIBC filtered):
/bin/sh
adwaita-icon-theme-legacy-devel (rpmlib, GLIBC filtered):
/usr/bin/pkg-config
adwaita-icon-theme-legacy
Provides
--------
adwaita-icon-theme-legacy:
adwaita-icon-theme-legacy
adwaita-legacy-icon-theme
adwaita-icon-theme-legacy-devel:
adwaita-icon-theme-legacy-devel
adwaita-legacy-icon-theme-devel
pkgconfig(adwaita-icon-theme-legacy)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2283710
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: C/C++, Java, R, SugarActivity, PHP, fonts, Haskell, Perl, Ocaml, Python
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/adwaita-icon-theme-legacy FEDORA-2024-43ab4edd0c (adwaita-icon-theme-46.2-2.fc40 and adwaita-icon-theme-legacy-46.2-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-43ab4edd0c FEDORA-2024-43ab4edd0c (adwaita-icon-theme-46.2-2.fc40 and adwaita-icon-theme-legacy-46.2-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |