Bug 2284285
| Summary: | Review Request: rust-jsonwebtoken - Create and decode JWTs in a strongly typed way | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/jsonwebtoken | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-07-06 00:20:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Davide Cavalca
2024-06-02 16:09:50 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=118460814 Copr build: https://copr.fedorainfracloud.org/coprs/build/7522380 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2284285-rust-jsonwebtoken/fedora-rawhide-x86_64/07522380-rust-jsonwebtoken/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. The crate ships quite a number of data files for tests. It would be good to exclude those from the -devel package somehow. The easiest solution would probably be to just drop the "tests/" directory, since no tests are referenced explicitly in Cargo.toml. Spec URL: https://dcavalca.fedorapeople.org/review/rust-jsonwebtoken/rust-jsonwebtoken.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-jsonwebtoken/rust-jsonwebtoken-9.3.0-1.fc41.src.rpm Changelog: - exclude tests/ from the devel package Looks good to me, thanks! === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-jsonwebtoken FEDORA-2024-d005c30062 (rust-jsonwebtoken-9.3.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-d005c30062 FEDORA-2024-d005c30062 (rust-jsonwebtoken-9.3.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-163045026b (rust-jsonwebtoken-9.3.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-163045026b FEDORA-2024-89695fb987 (rust-jsonwebtoken-9.3.0-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-89695fb987 FEDORA-2024-89695fb987 (rust-jsonwebtoken-9.3.0-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-163045026b (rust-jsonwebtoken-9.3.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |