Bug 2284289

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=118460839

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7522383
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2284289-rust-apple-dmg/fedora-rawhide-x86_64/07522383-rust-apple-dmg/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

The assets/example.dmg file is pretty large (2.1MB vs. 42KB in the rest of the crate). Not sure if this is used (or only used for tests).
If this is permissible content, please exclude it from getting installed into the -devel subpackage.

Looks like it's only used in a test:
https://github.com/indygreg/apple-platform-rs/blob/main/apple-dmg/src/lib.rs#L251

From inspection is looks like the dmg for the macOS app "raquote-winit", which seems to be some kind of example app using https://github.com/rust-windowing/winit. I can't find its sources anywhere, so I'm just going to strip this in %prep and disable the test to be on the safe side.

Spec URL: https://dcavalca.fedorapeople.org/review/rust-apple-dmg/rust-apple-dmg.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-apple-dmg/rust-apple-dmg-0.4.0-1.fc41.src.rpm

Changelog:
- strip DMG asset

$ cat rust2rpm.toml 
[scripts]
# Remove bundled DMG image of unclear origin
prep.pre = ["rm -r assets"]

[tests]
comments = ["Tests require the DMG we're stripping"]
run = ["none"]

Looks like a good solution to me, thanks!

===

Package was generated with rust2rpm, simplifying the review.

✅❌❓🫤

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-apple-dmg

FEDORA-2024-23573869b1 (rust-apple-dmg-0.4.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-23573869b1

FEDORA-2024-23573869b1 (rust-apple-dmg-0.4.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-11daf1f1cb (rust-apple-dmg-0.4.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-11daf1f1cb

FEDORA-2024-5711d6b0a7 (rust-apple-dmg-0.4.0-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-5711d6b0a7

FEDORA-2024-5711d6b0a7 (rust-apple-dmg-0.4.0-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-11daf1f1cb (rust-apple-dmg-0.4.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.