Bug 2284639
| Summary: | Review Request: rust-extreme - Extremely boring async function runner | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/extreme | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-07-06 00:20:40 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2284640 | ||
|
Description
Davide Cavalca
2024-06-03 17:34:07 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=118521356 $ cat rust2rpm.toml [package] description = "Extremely boring async function runner." Copr build: https://copr.fedorainfracloud.org/coprs/build/7525433 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2284639-rust-extreme/fedora-rawhide-x86_64/07525433-rust-extreme/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'GPL-3.0'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Version 666.666.666666? Seriously? ... There's some files that should be excluded from the "-devel" package in some ways: sanitizers.sh and tsan_suppressions.txt For example, the sanitizers.sh file causes RPM to generate a dependency on bash. Additionally, GPL-3.0 is not a valid SPDX identifier in recent versions of SPDX. It should be either GPL-3.0-only or GPL-3.0-or-later. (I assume the intention is GPL-3.0-only. The deprecated equivalent of GPL-3.0-or-later is GPL-3.0+). Spec URL: https://dcavalca.fedorapeople.org/review/rust-extreme/rust-extreme.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-extreme/rust-extreme-666.666.666666-1.fc41.src.rpm Changelog: - update license tag - drop unnecessary files $ cat rust2rpm.toml [package] description = "Extremely boring async function runner." [scripts] # Remove unnecessary scripts prep.pre = ["rm sanitizers.sh tsan_suppressions.txt"] You will need to update the license tag in Cargo.toml too, otherwise tooling like the %cargo_license macro will not pick up the change. Other than that, looks good to me! === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-extreme FEDORA-2024-b78058c802 (rust-extreme-666.666.666666-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b78058c802 FEDORA-2024-b78058c802 (rust-extreme-666.666.666666-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-95bdcfdd91 (rust-extreme-666.666.666666-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-95bdcfdd91 FEDORA-2024-3ede179598 (rust-extreme-666.666.666666-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-3ede179598 FEDORA-2024-3ede179598 (rust-extreme-666.666.666666-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-95bdcfdd91 (rust-extreme-666.666.666666-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |