Bug 228473
Summary: | Review Request: hunspell-es - Spanish hunspell dictionaries | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Caolan McNamara <caolanm> |
Component: | Package Review | Assignee: | manuel wolfshant <manuel.wolfshant> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | manuel.wolfshant |
Target Milestone: | --- | Flags: | manuel.wolfshant:
fedora-review+
notting: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-02-14 10:28:36 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Caolan McNamara
2007-02-13 09:50:38 UTC
GOOD - package meets naming guidelines - package meets packaging guidelines - spec file legible, in am. english - source matches upstream , sha1sum 3801efb6d6252e40a743a913afc4f86bb8d3a3ef es_ES.zip 4cc6bd6f5985d876f6d1bb565051b8131ddb82e4 es_MX.zip - the package builds in mock for devel/x86_64, generates a noarch (which is consistent with the fact that basically it includes only text files) - the license LGPL stated in the tag is the same as the one included in the source and is included in the package - there are only 2 files (word lists) + a short doc with instructions and license clearance, so no need for -doc and no .la, .pc, static files - no missing BR - no locales - not relocatable - owns all files/directories that it creates, does not take ownership of other files/dirs - no duplicate files - permissions ok - %clean ok - macro use consistent - rpmlint output is silent - code, not content - no need for -docs as the only doc are just the LGPL licenses (localised for Spain and Mexico) - nothing in %doc affects runtime - no need for .desktop file APPROVED PS: You could also add support for es_BZ (Belize), es_CU (Cuba), es_GU (Guatemala) Please bug upstream to update the corresponding Readme files on http://ftp.services.openoffice.org/pub/OpenOffice.org/contrib/dictionaries/, over there the license is stated to be GPL and not LGPL as the ones included in the zip files. Guatemala is es_GT I believe not es_GU and es_GT is one of the aliases already es_BZ, es_CU and es_GU don't appear in locale -a | grep es_ and they don't appear in the drop down of spanish languages in openoffice.org's format->character->font->language All those I have mentioned are listed as such at http://ftp.services.openoffice.org/pub/OpenOffice.org/contrib/dictionaries/README_es_ES.txt, under "Los siguientes son disponibles:" (The following are available) Interesting, I'd say the GU is a typo, unless it's an older unofficial locale replaced with GT. The other ones don't *seem* to be official locales yet, so aren't in glibc or OOo. I think I'll leave them out, easier to add them later in than have to pull them for conflicting with a future allocated locale. 27548 (hunspell-es): Build on target fedora-development-extras succeeded. |