Bug 228495
Summary: | Review Request: hunspell-pt - Portuguese hunspell dictionaries | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Caolan McNamara <caolanm> |
Component: | Package Review | Assignee: | manuel wolfshant <manuel.wolfshant> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | manuel.wolfshant |
Target Milestone: | --- | Flags: | manuel.wolfshant:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-02-15 14:43:44 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Caolan McNamara
2007-02-13 12:04:57 UTC
There are two dictionaries included, for pt_PT and pt_BR; each one comes with a Readme file (Leia-me.pdf). As they are not completely identical (for instance ine of them clarifies the license, while the other does not), please consider packaging them both GOOD - package meets naming guidelines - package meets packaging guidelines - spec file legible, in am. english - source matches upstream , sha1sum 0f000c39d4879c5008efe51d34daea89a94da271 pt_BR-2700g.zip 5b6c2f9d6e45b185174e2950e2b1e3a9fa1b6dd4 pt_PT-2700C.zip - the package builds in mock for devel/x86_64, generates a noarch (which is consistent with the fact that basically it includes only 3 text files) - MUSTFIX the license (GPL) stated in the tag is not the same as the web site says. http://www.broffice.org.br/?q=docs claims "Creative Commons (padrão) - GNU FDL - ODL" while one of the included readme files claims LGPL. - the package includes just word lists + docs with instructions and license clearance, so no need for -doc and no .la, .pc, static files - no missing BR - no locales - not relocatable - owns all files/directories that it creates, does not take ownership of other files/dirs - no duplicate files - permissions ok - %clean ok - macro use consistent - rpmlint output is silent - code, not content - nothing in %doc affects runtime - no need for .desktop file please fix the differences between the license tag and the ones from upstream and I will approve the package. Please also try to persuade upstream to include the licenses in the archives. It's a little confusing here, the http://www.broffice.org.br/?q=docs page seems to be the license for "collaboration with the Documentation of the BrOffice.org in case that you have developed some proper documentation (tutorial, etc)" while at http://www.broffice.org.br/?q=verortografico from where the dictionary website makes these available for download has text of roughly... "It is easy to collaborate, sees. You observe, when typing one definitive text in the BrOffice.org, that an incorrect word was colored in red. There you in them send an email telling this word. If to prefer will be able to join a series of words and to send them later. The same valley for incorrect words that are validated by the Ortográfico Verifier. It saw as is easy? Then, what you are waiting. IT ROLLS UP SLEEVES, and it comes to participate of this project. Remembering that our participation is voluntary and is based in license LGPL. Our email is in the end of this page." So the pt-PT has a readme saying it is LGPL and the pt-BR doesn't have one in the package, but the broffice.org people who wrote the pt-BR dictionary state on the download page that participation by submitting to the dictionary will be under the LGPL. Hence I've adjusted the licence to be LGPL in the spec. Me too I would have modified the tag to LGPL :) Once the servers sync I'll verify and approve. Problems fixed. Package APPROVED (Would have done it sooner if the separate .spec was updated too...) 27643 (hunspell-pt): Build on target fedora-development-extras succeeded. |