Bug 228500

Summary: Review Request: hunspell-sv - Swedish hunspell dictionaries
Product: [Fedora] Fedora Reporter: Caolan McNamara <caolanm>
Component: Package ReviewAssignee: manuel wolfshant <manuel.wolfshant>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: manuel.wolfshant
Target Milestone: ---Flags: manuel.wolfshant: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-02-15 14:52:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779    

Description Caolan McNamara 2007-02-13 12:22:34 UTC 
Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-sv.spec
SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-sv-1.3.8.6-1.src.rpm
Description: Swedish hunspell dictionaries


Similar to 227811
Comment 1 manuel wolfshant 2007-02-14 11:45:11 UTC 
GOOD

- package meets naming guidelines
- package meets packaging guidelines 
- spec file legible, in am. english
- source matches upstream , sha1sum 

- the package builds in mock for devel/x86_64, generates a noarch (which is
consistent with the fact that basically it includes only 3 text files)
- the license LGPL stated in the tag is the same as the one included in the
package  (as COPYING)
- there are only 2 files (word lists) + a couple of docs, so no need for -doc
and no .la, .pc, static files
- no missing BR
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of other
files/dirs
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- rpmlint output is silent
- code, not content
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED
Comment 2 Caolan McNamara 2007-02-15 14:52:14 UTC 
 27646 (hunspell-sv): Build on target fedora-development-extras succeeded.