Bug 228502
| Summary: | autofs don't understand -null | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 4 | Reporter: | Ralf Brunckhorst <ralf.brunckhorst> | ||||||||
| Component: | autofs | Assignee: | Jeff Moyer <jmoyer> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Brock Organ <borgan> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | high | ||||||||||
| Version: | 4.4 | CC: | ikent, matseitz | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | RHBA-2007-0734 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2007-11-15 16:02:17 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Ralf Brunckhorst
2007-02-13 12:28:24 UTC
Created attachment 147981 [details]
diff for changed autofs start-script that enable the -null feature
Could you please re-generate this diff using the "-u" option? Something like: diff -up /etc/init.d/autofs.orig /etc/init.d/autofs > autofs.diff Then, attach that file to the bugzilla. The diff you provided is incomplete (it doesn't contain header information, like which file it is a diff of). I also couldn't manually apply it to the 4.1.3-187 code base, so something is amiss. Thanks! Created attachment 147998 [details]
new autofs diff file
Hope that this work now, Ralf.
For FC there is a working autofs version, but we need it for RHEL-4. Created attachment 151684 [details]
Add support for -null map handling
The patch posted previously was a less than ideal solution. I would rather add
explicit handling for "-null" as an option as opposed to relying on
undocumented ordering of variable assignment in the init script.
So, here's a replacement patch. It works in my environment. Please test it.
Hi, was on vacation. I have tested your patch, it works also for me but the patch should be: fi done + if [ "$map" == "-null" ]; then + knownmaps=" $dir/ $knownmaps" + continue + fi + if [ ! -z "$dir" -a ! -z "$map" \ -a x`echo "$map" | cut -c1` != 'x-' ] then (In reply to comment #7) > Hi, was on vacation. I have tested your patch, it works also for me but the > patch should be: > fi > done > > + if [ "$map" == "-null" ]; then > + knownmaps=" $dir/ $knownmaps" > + continue > + fi > + > if [ ! -z "$dir" -a ! -z "$map" \ > -a x`echo "$map" | cut -c1` != 'x-' ] > then Thanks for testing. I don't see how the above is different from the posted patch. Could you explain, please? Sorry, it is the same. Maybe I made a copy/paste mistake. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. Thank you for providing the patch. I used it to fix a problem with an NIS auto.master entry that was invalid for my system. I look forward to having this included in an official update. An RHTS regression test was createad for this under autofs-tests/bugzillas, subtest bz228502. This fix was committed to autofs-4.1.3-222 (though I missed it in the changelog; I'll fix that on the next build). The patch was committed to CVS. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2007-0734.html |