Bug 228591
Summary: | Review Request: speedcrunch - a KDE power user calculator | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Roland Wolters <roland.wolters> | ||||
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | chitlesh, rdieter, wtogami | ||||
Target Milestone: | --- | Flags: | panemade:
fedora-review+
wtogami: fedora-cvs+ |
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2007-02-25 02:43:58 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 163779 | ||||||
Attachments: |
|
Description
Roland Wolters
2007-02-13 21:44:44 UTC
mock build is fine. But rpmlint reported warnings W: speedcrunch wrong-file-end-of-line-encoding /usr/share/doc/speedcrunch-0.7/README This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: speedcrunch wrong-file-end-of-line-encoding /usr/share/doc/speedcrunch-0.7/ChangeLog This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: speedcrunch wrong-file-end-of-line-encoding /usr/share/doc/speedcrunch-0.7/COPYING This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. ==> Above can be fixed easily. See http://fedoraproject.org/wiki/Packaging/CommonRpmlintIssues#head-a0f61366f8eb114896cb4db188ee22b3d273f3a8 W: speedcrunch mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 10) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. Use sed -i -e 's|\t| |g' speedcrunch.spec I saw configure script in tarball. Why its not used? The configure was not used because cmake is provided and it is likely that all newer KDE related applications switch to cmake and drop the autotools sooner or later. Of course if preferred I can also use configure. About the line end encoding: I'm not sure how I should change the files. I can generate a patch file which would be exactly as big as the mentioned files. Is there a save way to call sed in the spec file? (In reply to comment #3) > The configure was not used because cmake is provided and it is likely that all > newer KDE related applications switch to cmake and drop the autotools sooner > or later. Of course if preferred I can also use configure. Then its ok. No problem. > > About the line end encoding: I'm not sure how I should change the files. I can > generate a patch file which would be exactly as big as the mentioned files. Is > there a save way to call sed in the spec file? its simple to call sed in spec. Have you checked link given comment #1? Created attachment 148098 [details]
Use this SPEC
Bump the release. Add ChangeLog in SPEC.
The new srpm is here: http://www.personal.uni-jena.de/~p1woro/fedorarpms/speedcrunch-0.7-beta2.2.src.rpm I replaced the old spec, just take the link from above. About the line encoding: yes, I read the comment but wasn't unsure if to call the argument from the spec or if I should provide a patch. So I just included the line like in your attached spec (and changed the tab-space stuff and the version number, etc). Forgot to mention that I didn't replaced the old spec but corrected it according to your suggestions. The reason is that I want to learn from my mistakes and don't want you to do my work ;) rpmlint has no errors at all on this new version on the src.rpm, the rpm or the debug-rpm. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM + source files match upstream. e9a94f6a054c1332483024ee035d3a79 speedcrunch-0.7-beta2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + translations are available but not handled with %find_lang. + Dose owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. - Desktop file installed correctly but not able to view it under Applications Menu. + GUI app. SHOULD: desktop file should be viewable under applications menu. Update Desktop file and submit new package. "Update Desktop file" - Sorry, I don't know what to update, the desktop file is exactly made like the example in 'Guidelines#desktop' What Categories=... are listed in it's .desktop file? For example, kcalc (in kdeutils) includes: Categories=Qt;KDE;Utility;X-KDE-Utilities-Desktop; Categories=Engineering; (The same as the Group in the spec file) Should I switch that? It should include a "Main" Category, see http://standards.freedesktop.org/menu-spec/latest/apa.html All other Categories are optional, they're not guarranteed to be supported (ie, appear in menus). I added Utility as a category, the new spec file is here: http://www.personal.uni-jena.de/~p1woro/fedorarpms/speedcrunch.spec The new src.rpm is here: http://www.personal.uni-jena.de/~p1woro/fedorarpms/speedcrunch-0.7-beta2.3.src.rpm For Release, use (something like): Release: 0.1.beta2%{?dist} Per http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-e104844825856d7c45f2f0241586985c0495966b Changed it, the spec file is at the usual place, the new src rpm is here: http://www.personal.uni-jena.de/~p1woro/fedorarpms/speedcrunch-0.7-0.4.beta2.src.rpm Thanks Rex for pointing Naming of package. Thanks Ronald for adding correct Category to Desktop file. Now i can see Menu option under Applications. APPROVED. According to "NewPackageProcess" I now have to do the steps described at "CVSAdminProcedure". So I added the following snippet and flagged 'fedora cvs' with a '?', but got the error "New Package CVS RequestYou tried to request fedora-cvs. Only a sufficiently empowered user can make this change." What am I supposed to do now? ======================= Package Name: speedcrunch Short Description: high precision KDE calculator Owners: wolters.liste Branches: FC-5 FC-6 InitialCC: > but got the error "New Package CVS RequestYou tried to
> request fedora-cvs. Only a sufficiently empowered user can make this change."
> What am I supposed to do now?
This means that you were not a member of the fedorabugs group. Is this now
corrected?
I never requested to be a member of fedorabugs because these people are also allowed to approve packages, according to this page: http://fedoraproject.org/wiki/Extras/Contributors I don't think that I am skilled enough to make formal approvements, but since the membership is even needed to finish a normal review I requested the membership in the account system. The Role Status is "unapproved" at the moment. Builds in devel. Package Change Request ====================== Package Name: speedcrunch Updated Fedora CC: Rex Dieter (rdieter.edu) Please make him co-maintainer. This review is used for this procedure because it was stated to do so: http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure |