Bug 228713
| Summary: | [RHEL4] [patch] cid-2 remove dead code in lib/ss/help.c | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 4 | Reporter: | Bryn M. Reeves <bmr> | ||||
| Component: | e2fsprogs | Assignee: | Eric Sandeen <esandeen> | ||||
| Status: | CLOSED NOTABUG | QA Contact: | Jay Turner <jturner> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 4.4 | CC: | sct, srevivo | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-05-30 18:33:42 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 234251, 239341 | ||||||
| Attachments: |
|
||||||
Created attachment 148063 [details]
Remove invariant (code != 0) check in lib/ss/help.c
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. This patch was not accepted upstream since this was NAK'd upstream, coupled with the fact that dead code removal isn't really acceptable for rhel changes, setting this one to NOTABUG. http://lists.openwall.net/linux-ext4/2007/03/18/4 |
Description of problem: lib/ss/help.c contains the following lines in ss_help(): request_name = ss_current_request(sci_idx, &code); if (code != 0) { ss_perror(sci_idx, code, ""); return; /* no ss_abort_line, if invalid invocation */ } However, ss_current_request is defined in lib/ss/ss_internal.h as: #define ss_current_request(sci_idx,code_ptr) \ (*code_ptr=0,ss_info(sci_idx)->current_request) Since this clears &code, the conditional following the macro is not necessary. Version-Release number of selected component (if applicable): e2fsprogs-1.35-12.4.EL4 How reproducible: Not really reproducible, since the ss_perror line is never executed anyway.