Bug 2290556

Summary: uwsgi fails to build with Python 3.13: unknown type name ‘_PyCFrame’, implicit declaration of function ‘_PyImport_AcquireLock`, ‘_PyImport_ReleaseLock’, ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘cframe’
Product: [Fedora] Fedora Reporter: Karolina Surma <ksurma>
Component: uwsgiAssignee: Ralf Ertzinger <redhat-bugzilla>
Status: CLOSED WORKSFORME QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: fti-bugs, ksurma, mhroncok, python-packagers-sig, redhat-bugzilla, xavier
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-08-16 07:38:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2260875, 2244836, 2260877    
Attachments:
Description Flags
fix python 3.13 build failure patch none

Description Karolina Surma 2024-06-05 14:18:49 UTC
uwsgi fails to build with Python 3.13.0b1.

+ /usr/bin/python3 uwsgiconfig.py --verbose --plugin plugins/python fedora python3
In file included from plugins/python/python_plugin.c:1:
plugins/python/uwsgi_python.h:178:9: error: unknown type name ‘_PyCFrame’
  178 |         _PyCFrame **current_frame;
      |         ^~~~~~~~~
plugins/python/python_plugin.c: In function ‘uwsgi_python_pre_uwsgi_fork’:
plugins/python/python_plugin.c:1345:17: error: implicit declaration of function ‘_PyImport_AcquireLock’ [-Wimplicit-function-declaration]
 1345 |                 _PyImport_AcquireLock(interp);
      |                 ^~~~~~~~~~~~~~~~~~~~~
plugins/python/python_plugin.c: In function ‘uwsgi_python_post_uwsgi_fork’:
plugins/python/python_plugin.c:1362:25: error: implicit declaration of function ‘_PyImport_ReleaseLock’ [-Wimplicit-function-declaration]
 1362 |                         _PyImport_ReleaseLock(interp);
      |                         ^~~~~~~~~~~~~~~~~~~~~
plugins/python/python_plugin.c: In function ‘uwsgi_python_suspend’:
plugins/python/python_plugin.c:1624:62: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘cframe’
 1624 |                 up.current_frame[wsgi_req->async_id] = tstate->cframe;
      |                                                              ^~


https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13-b1/fedora-rawhide-x86_64/07532239-uwsgi/

For all our attempts to build uwsgi with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13-b1/package/uwsgi/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13-b1/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Karolina Surma 2024-06-12 15:11:48 UTC
*** Bug 2292016 has been marked as a duplicate of this bug. ***

Comment 2 Fedora Fails To Install 2024-06-19 20:00:04 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 3 Fedora Fails To Install 2024-07-13 08:02:30 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 4+ weeks.
This is the second reminder (step 4) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 4 Fedora Fails To Install 2024-08-13 00:02:44 UTC
This package has been orphaned.

You can pick it up at https://src.fedoraproject.org/rpms/uwsgi by clicking button "Take". If nobody picks it up, it will be retired and removed from a distribution.

Comment 5 Xavier Bachelot 2024-08-13 08:56:19 UTC
Created attachment 2044080 [details]
fix python 3.13 build failure patch

Comment 6 Xavier Bachelot 2024-08-13 08:59:01 UTC
Hi Ralf,

Here's a patch that should fix the python 3.13 build failure, but I have not yet fixed the gcc 14 issue below:

plugins/python/python_plugin.c: In function ‘uwsgi_python_pre_uwsgi_fork’:
plugins/python/python_plugin.c:1345:17: error: implicit declaration of function ‘_PyImport_AcquireLock’ [-Wimplicit-function-declaration]
 1345 |                 _PyImport_AcquireLock(interp);
      |                 ^~~~~~~~~~~~~~~~~~~~~
plugins/python/python_plugin.c: In function ‘uwsgi_python_post_uwsgi_fork’:
plugins/python/python_plugin.c:1362:25: error: implicit declaration of function ‘_PyImport_ReleaseLock’ [-Wimplicit-function-declaration]
 1362 |                         _PyImport_ReleaseLock(interp);
      |                         ^~~~~~~~~~~~~~~~~~~~~

I hope that helps,
Xavier

Comment 7 Ralf Ertzinger 2024-08-13 09:09:23 UTC
Hi,

thanks for the patch. I grabbed one from a MR from the upstream project instead, and the code builds, but I haven't run tests yet, hope to do some basic testing later today

Comment 8 Ralf Ertzinger 2024-08-13 19:14:39 UTC
There's a build at https://copr.fedorainfracloud.org/coprs/build/7905383 that hasn't blown up for me so far in testing

Comment 9 Fedora Fails To Install 2024-08-16 07:37:05 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 42.

Thanks for taking care of it!

Comment 10 Fedora Fails To Install 2024-08-16 07:38:20 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 41.

Thanks for taking care of it!