Bug 2290575
| Summary: | Review Request: rust-serde_default - Generate a Default impl using serde attributes | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | wojnilowicz <lukasz.wojnilowicz> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/serde_default | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-07-07 08:35:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
wojnilowicz
2024-06-05 15:34:45 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7532832 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290575-rust-serde_default/fedora-rawhide-x86_64/07532832-rust-serde_default/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. This package has pretty outdated dependencies. Could you try to work with upstream to port this crate to syn v2 and darling v0.20? === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-serde_default FEDORA-2024-85cf041ba8 (rust-serde_default-0.1.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-85cf041ba8 FEDORA-2024-85cf041ba8 (rust-serde_default-0.1.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. Thank you for the review! Regarding (In reply to Fabio Valentini from comment #2) > This package has pretty outdated dependencies. Could you try to work with > upstream to port this crate to syn v2 and darling v0.20? I could try to look into this. I'm not a rust developer though, so I guess I'll at least notify them. Upstream ported the crated themselves to newer versions as can be seen at https://github.com/TedDriggs/serde_default/blob/master/Cargo.toml#L14 It seems that they haven't tagged a new version yet. (In reply to wojnilowicz from comment #7) > Upstream ported the crated themselves to newer versions as can be seen at > https://github.com/TedDriggs/serde_default/blob/master/Cargo.toml#L14 > It seems that they haven't tagged a new version yet. Ah, great! So at least this problem will go away in the future as soon as there's a new release that we can package. Thanks for checking! |