Bug 2290698

Summary: Review Request: rust-hmac-sha512 - A small, self-contained SHA512 and HMAC-SHA512 implementation
Product: [Fedora] Fedora Reporter: Oliver Steffen <osteffen>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: berrange, crobinso, decathorpe, kraxel, osteffen, package-review, zbyszek
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: decathorpe: fedora-review+
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/hmac-sha512
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-07-10 14:44:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Oliver Steffen 2024-06-06 10:20:42 UTC
Spec URL: https://osteffen.fedorapeople.org/packages/rust-hmac-sha512/rust-hmac-sha512.spec
SRPM URL: https://osteffen.fedorapeople.org/packages/rust-hmac-sha512/rust-hmac-sha512-1.1.5-1.fc41.src.rpm
Description: A small, self-contained SHA512 and HMAC-SHA512 implementation in Rust.
Also includes SHA384 and HMAC-SHA384, that are just truncated versions of SHA512  with a different IV.
Fedora Account System Username: osteffen

This crate is packaged directly from crates.io without any modifications.

This is part of the effort to add the Coconut-SVSM paravisor to Fedora.
It would enables Fedora virtualization hosts to launch confidential
virtual machines using AMD's SEV-SNP technology.
See https://fedoraproject.org/wiki/Changes/ConfidentialVirtHostAMDSEVSNP

Comment 1 Fedora Review Service 2024-06-06 10:30:53 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7542855
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290698-rust-hmac-sha512/fedora-rawhide-x86_64/07542855-rust-hmac-sha512/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-07-05 14:12:13 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Fedora Admin user for bugzilla script actions 2024-07-10 13:07:52 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-hmac-sha512

Comment 4 Fedora Update System 2024-07-10 13:22:50 UTC
FEDORA-2024-09caeb48b7 (rust-hmac-sha512-1.1.5-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-09caeb48b7

Comment 5 Fedora Update System 2024-07-10 14:44:30 UTC
FEDORA-2024-09caeb48b7 (rust-hmac-sha512-1.1.5-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.