Bug 229098
| Summary: | Review Request: openjpeg - JPEG 2000 codec library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Callum Lerwick <seg> |
| Component: | Package Review | Assignee: | Xavier Lamien <lxtnow> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | adam, bos, hdegoede, kwizart, lemenkov, mtasaka, opensource |
| Target Milestone: | --- | Flags: | lxtnow:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.2-3.20071114svn480.fc7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-11-26 18:38:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 233946 | ||
|
Description
Callum Lerwick
2007-02-17 00:26:37 UTC
from spec:
* You should add timestamps INSTALL="install -p" to your make install.
* replace openjpeg by it macros %{name}
* you forgot to comment why patch0 was set.
rpmlint ouput error on -devel package: no-documentation. ping ? Sorry, I got tied up with other things. Updated package: http://www.haxxed.com/rpms/secondlife/openjpeg-1.1-2.src.rpm http://www.haxxed.com/rpms/secondlife/openjpeg.spec * Sat Feb 17 2007 Callum Lerwick <seg> 1.1-2 - Move header to a subdirectory. - Fix makefile patch to preserve timestamps during install. I hate using macros unless there's a really good reason. The package name is very unlikely to change, and on the rare occasion that it might, a search and replace isn't a big deal. So I avoid using %{name} The no-doc warning on the devel package is ignoreable. The main package has docs. Hmmm, I actually need to go over the docs, README.linux shouldn't be packaged and ChangeLog might be better in the devel package. And where's the license... I figure the purpose of the makefile patch is self evident, based on the name and by taking a look at it. I put in a comment for the others because otherwise it would not be clear that they're there for the benefit of another package. And... looks like OpenJPEG 1.1.1 was just released. Which seems to have the SL patches merged in. Working on it now... http://www.haxxed.com/rpms/secondlife/openjpeg-1.1.1-1.src.rpm http://www.haxxed.com/rpms/secondlife/openjpeg.spec * Fri Feb 23 2007 Callum Lerwick <seg> 1.1.1-1 - New upstream version, which has the SL patches merged. I still need to email upstream about including the license. > I still need to email upstream about including the license.
You should add the licence text as source in the meantime you're waitting an
answer from upstream.
Can be approuved without this.
For the rest i'll check out your files.
s/Can/Can't Ping ? http://www.haxxed.com/rpms/secondlife/openjpeg.spec http://www.haxxed.com/rpms/secondlife/openjpeg-1.1.1-2.src.rpm * Fri Mar 16 2007 Callum Lerwick <seg> 1.1.1-2 - Link with libm, fixes building on ppc. i386 and x86_64 are magical. I still need to talk to upstream about including the license. They do seem to be interested in the performance tweaks I came up with. :) http://www.haxxed.com/code/openjpeg-1.1.1-t1-optimize.20070330.patch Well, any answers from upstream about license ? I finally managed to catch upstream's attention. :) The license is in svn now and a new release should be coming soonish, with the license and some of the optimizations me and others have been working on... ping ? Any news about new release ? I will close this bug as NOTABUG if any response from the reporter is gained within one week http://fedoraproject.org/wiki/Extras/Policy/StalledReviews re: ping ? Callum, any news from upstream ? if not, what about svn trunck ? I just submitted a bunch of patches yesterday, they may have been waiting on that. I have a package based on SVN, however the ABI has sort of broken due to a bunch of stuff for Cinema4k being added to the encoder parameter structure. Upstream tried to prevent it, but on Fedora, it still crashes apps with "stack smashing detected". Not sure how to deal with this. (In reply to comment #16) > I just submitted a bunch of patches yesterday, they may have been waiting on > that. I have a package based on SVN, however the ABI has sort of broken due to a > bunch of stuff for Cinema4k being added to the encoder parameter structure. > Upstream tried to prevent it, but on Fedora, it still crashes apps with "stack > smashing detected". Not sure how to deal with this. The only way to solve this is to give the new version a new soname (preferably working with upstream), and then do a compat package for the old version, if the new version is still API compatible, the compat package doesn't need a parallel installable -devel and thus should be easy. Hi! 4 June 2007: Version 1.2 Released Callum, any news? My upgrade to F7 went smoothly as usual. (note: sarcasm) I'll upload an updated package shortly. http://www.haxxed.com/rpms/secondlife/openjpeg.spec http://www.haxxed.com/rpms/secondlife/openjpeg-1.2-1.fc7.src.rpm * Sun Jun 10 2007 Callum Lerwick <seg> 1.2-1 - Build the mj2 tools as well. - New upstream version, ABI has broken, upstream has bumped soname. (In reply to comment #21) > - New upstream version, ABI has broken, upstream has bumped soname. Since this is still under review, and thius not in Fedora, we do not have anything depending on this already in the repo, right? Then this shouldn't be a problem. (in reply to comment #22) >> Since this is still under review, and thius not in Fedora, we do not have >> anything depending on this already in the repo, right? Then this shouldn't be a >> problem. indeed, this souldn't well, starting the review... OK - Mock : Built on F-7 (x86_64) ? - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License field in spec matches OK - License is GPL OK - License match extras packaging policy licenses allowed OK - License file is included in package OK - Spec in American English OK - Spec is legible. OK - Sources SHOULD match upstream md5sum: 4973c564c96683a921a7f6759906da4e openjpeg_v1_2.tar.gz OK - Package has correct buildroot. OK - extras BuildRequires are not redundant. OK - %build and %install stages are correct and work. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories that other packages own. OK - Changelog section is correct. OK - Should function as described. OK - Should package latest version ------------------------------------------- Rpmlint output: ------------------------------------------- OK - silent on both srpm and main/sub package rpm ------------------------------------------- Sub-packages: ------------------------------------------- They need some improvment. according to the scheme of opengjpeg the main package should contain all bin files, that imply to remove -bin subpackage (which not really usefull). And if other packages work with/need-to openjpeg lib for developping work, provide a subpackage named -lib or -n libopenjpeg. Also Changelog file should be in the main package. Callum: ping ? Again ping? Last ping ! Hmmm, I'm trying to get some patches upstreamed. I should probably get a new package out in the mean time. http://www.haxxed.com/rpms/secondlife/openjpeg.spec http://www.haxxed.com/rpms/secondlife/openjpeg-1.2-2.20070808svn.fc7.src.rpm * Thu Aug 09 2007 Callum Lerwick <seg> 1.2-2.20070808svn - Put binaries in main package, move libraries to -libs subpackage. Based on an SVN snapshot, with a whole load of patches that I'm trying to get upstream, that speeds it up about 25%... Okay,
All issues above has been fixed.
However,
the release tag need to be fix.
As a pre-release svn checkout, its should be set like this: 0.%{X}.%{alphatag}
So move it to "0.1.%{snapshot}%{?dist}" instead of "2.%{snapshot}%{?dist}".
Also note that as an snapshot version, you should comment above the source0 the
svn external link to get the source.
@Xavier This is a post release, so 2 is right in this case... @Callum About the snapshoot, it is often recommanded to use a bash script to retrieve the sources (and remove CVS or .svn ), so you can have a method to compare differents snapshoots... This script have to be provided also (Source10)... You can find an sample in the dirac cvs directory if you want... (In reply to comment #31) > @Callum > About the snapshoot, it is often recommanded to use a bash script to retrieve > the sources (and remove CVS or .svn ), so you can have a method to compare The Guidelines demand a documented way how to create a snapshot tarball: http://fedoraproject.org/wiki/Packaging/SourceURL#head-615f6271efb394ab340a93a6cf030f2d08cf0d49 And a hint for svn: You can use "svn export" instead of "svn co" to avoid the creation of .svn directories. ping? Again ping? it's ok for me. This package needs cvs to be Requested by the Reporter. See: http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure ping again? By the way: (In reply to comment #29) > http://www.haxxed.com/rpms/secondlife/openjpeg.spec > http://www.haxxed.com/rpms/secondlife/openjpeg-1.2-2.20070808svn.fc7.src.rpm > > * Thu Aug 09 2007 Callum Lerwick <seg> 1.2-2.20070808svn > - Put binaries in main package, move libraries to -libs subpackage. Rebuild fails at least on ppc and ppc64. http://koji.fedoraproject.org/koji/taskinfo?taskID=224231 Hmmm, yeah that's something I've fixed already. :) I've got a bit distracted by high memory usage and serious memory leakage in recent Second Life clients. The leakage seemed to have been a Mesa/DRI bug or something, but I guess we just have to live with higher memory usage for now. SL really doesn't run very well on 512mb anymore. Again ping, Callum? If this package is okay, please do CVS procedure ( http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure ) http://www.haxxed.com/rpms/secondlife/openjpeg.spec http://www.haxxed.com/rpms/secondlife/openjpeg-1.2-3.20071114svn480.fc7.src.rpm * Thu Aug 09 2007 Callum Lerwick <seg> 1.2-3.20071114svn480 - Build using cmake. - New snapshot. I think I'm doing snapshots the way the guidelines want me to now. Not that I want to make a habit of using snapshots. The major performance optimizations got merged upstream, and a new release should be coming in the next week. :) New Package CVS Request ======================= Package Name: openjpeg Short Description: JPEG 2000 codec library Owners: seg Branches: F-7 F-8 InitialCC: seg Cvsextras Commits: yes cvs done. openjpeg-1.2-3.20071114svn480.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update openjpeg' openjpeg-1.2-3.20071114svn480.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update openjpeg' openjpeg-devel-1.2-3.20071114svn480.fc8 openjpeg.h header file and library do
not match. Installed on Fedora 8 system fully updated as of 11/25/2007
Simple program: openjpegtest.c
#include <stdio.h>
#include <openjpeg/openjpeg.h>
int main( void ) { return 0; }
Compile:
gcc -o tmp.out openjpegtest.c -lopenjpeg
Results:
/usr/lib/gcc/i386-redhat-linux/4.1.2/../../../libopenjpeg.so: undefined
reference to `floor'
/usr/lib/gcc/i386-redhat-linux/4.1.2/../../../libopenjpeg.so: undefined
reference to `ceilf'
/usr/lib/gcc/i386-redhat-linux/4.1.2/../../../libopenjpeg.so: undefined
reference to `floorf'
/usr/lib/gcc/i386-redhat-linux/4.1.2/../../../libopenjpeg.so: undefined
reference to `lrintf'
/usr/lib/gcc/i386-redhat-linux/4.1.2/../../../libopenjpeg.so: undefined
reference to `pow'
collect2: ld returned 1 exit status
Looks like a math include got left out
(In reply to comment #46) > openjpeg-devel-1.2-3.20071114svn480.fc8 openjpeg.h header file and library do > not match. Installed on Fedora 8 system fully updated as of 11/25/2007 > <snip> You need to add -lm to the cmdline when linking Yeah, that's a link error. gcc *should* be replacing those functions with inline code on i386, though. openjpeg-1.2-3.20071114svn480.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. openjpeg-1.2-3.20071114svn480.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: openjpeg New Branches: EL-5 Owners: agoode cvs done. |