Bug 2291888

Summary: python-pyunicorn fails to build in Fedora Rawhide: SystemError: <method 'distances' of 'igraph._igraph.GraphBase' objects> returned NULL without setting an exception
Product: [Fedora] Fedora Reporter: Fedora Fails To Install <fti-bugs>
Component: python-pyunicornAssignee: Ankur Sinha (FranciscoD) <sanjay.ankur>
Status: CLOSED RAWHIDE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 42CC: gui1ty, ksurma, mhroncok, neuro-sig, sanjay.ankur
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-pyunicorn-0.7.0~a1-9.20230730gitmaster.fc42 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-03-18 22:08:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2291596, 2291633, 2291644    
Bug Blocks: 2300529, 2244836    

Description Fedora Fails To Install 2024-06-12 11:29:01 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

Your package (python-pyunicorn) Fails To Install in Fedora 41:

can't install python3-pyunicorn:
  - nothing provides python(abi) = 3.12 needed by python3-pyunicorn-0.7.0~a1-5.20230730gitmaster.fc40.x86_64
  - nothing provides python3.12dist(h5netcdf) >= 1.1 needed by python3-pyunicorn-0.7.0~a1-5.20230730gitmaster.fc40.x86_64
  - nothing provides python3.12dist(igraph) >= 0.10 needed by python3-pyunicorn-0.7.0~a1-5.20230730gitmaster.fc40.x86_64
  - nothing provides python3.12dist(numpy) >= 1.24 needed by python3-pyunicorn-0.7.0~a1-5.20230730gitmaster.fc40.x86_64
  - nothing provides python3.12dist(scipy) >= 1.10 needed by python3-pyunicorn-0.7.0~a1-5.20230730gitmaster.fc40.x86_64
  
If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem.


If you don't react accordingly to the policy for FTBFS/FTI bugs (https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/), your package may be orphaned in 8+ weeks.


P.S. The data was generated solely from koji buildroot, so it might be newer than the latest compose or the content on mirrors. To reproduce, use the koji/local repo only, e.g. in mock:

    $ mock -r fedora-41-x86_64 --config-opts mirrored=False install python3-pyunicorn


P.P.S. If this bug has been reported in the middle of upgrading multiple dependent packages, please consider using side tags: https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/#updating-inter-dependent-packages

Thanks!

Comment 1 Karolina Surma 2024-06-26 08:40:38 UTC
The dependencies are all sorted out, but 29 tests fail during the %check with:

            return np.array(
>               self.graph.distances(weights=link_attribute, mode=1))
E           SystemError: <method 'distances' of 'igraph._igraph.GraphBase' objects> returned NULL without setting an exception

See: https://kojipkgs.fedoraproject.org/work/tasks/4149/119604149/build.log

Comment 2 Sandro 2024-06-26 09:39:16 UTC
This appears to be an issue with Python 3.13. The package builds fine on F40, which has the same version of `igraph`. Reported upstream.

Comment 3 Sandro 2024-06-27 08:07:34 UTC
Response from upstream (sigh):

> Python 3.13 builds are not yet included in [Pyunicorn's CI](https://github.com/pik-copan/pyunicorn/blob/3079fdaff333c6254d322003d1c93ea1eb22f5ff/.travis.yml#L39-L45). Will definitely look into this in the future. Currently, Python 3.8/3.9/3.10/3.11/3.12 are actively maintained.
> 
> If you need to run Python 3.13 and can find a fix, feel free to send a PR! šŸ™‚

Rather than being prepared, they prefer to wait until šŸ’© hits fan? I mean Python 3.13 is actively maintained, just not released yet.

Well, pyunicorn is a leaf package. I guess we can sit this one out.

Comment 4 Miro Hrončok 2024-09-27 10:17:11 UTC
> I guess we can sit this one out.

So, retire the package?

Comment 5 Ankur Sinha (FranciscoD) 2024-09-27 10:38:22 UTC
(In reply to Miro Hrončok from comment #4)
> > I guess we can sit this one out.
> 
> So, retire the package?

If that's what the Fedora policies require, yep. We'll unretire it when it's fixed upstream.

I will note that Py3.13, irrespective of how well maintained it is, is still an unreleased version of Python until the 1st of October. So upstreams are withing their rights to say "we'll support it when it's released". They're not expected to proactively work to support unreleased software versions (Python or others), and we should be mindful of that. (This also goes for numpy2.x for example---most upstreams will not actively keep an eye on numpy changes and only began working on fixes after numpy2.x was released).

Comment 6 Ankur Sinha (FranciscoD) 2024-09-27 10:40:12 UTC
Having said all that, it looks like they did make a fix for py3.13: https://github.com/igraph/python-igraph/commit/8abba79c19675f39e4648e9b03bcd000b965ee3c

I'll go see if that fixes our build now.

Comment 7 Miro Hrončok 2024-09-27 10:45:45 UTC
(In reply to Ankur Sinha (FranciscoD) from comment #6)
> Having said all that, it looks like they did make a fix for py3.13:
> https://github.com/igraph/python-igraph/commit/
> 8abba79c19675f39e4648e9b03bcd000b965ee3c
> 
> I'll go see if that fixes our build now.

Awesome!

Comment 8 Ankur Sinha (FranciscoD) 2024-09-27 11:51:26 UTC
It's actually a fix in python-igraph, not pyunicorn (but python-igraph didn't ever FTBFS probably because it doesnt run any tests, nor check imports?). I'll submit a PR for that now, and am testing if the igraph fix also fixes pyunicorn in a COPR here:

https://copr.fedorainfracloud.org/coprs/ankursinha/pyunicorn/builds/

Comment 9 Miro Hrončok 2024-09-27 12:04:38 UTC
I think so. I have an enable-test commit ready in https://src.fedoraproject.org/fork/churchyard/rpms/python-igraph/commits/test-fix3.13 in case you want to take it.

Comment 10 Ankur Sinha (FranciscoD) 2024-09-27 12:22:36 UTC
Ah, sorry, I did that too. Just opened a PR:

https://src.fedoraproject.org/rpms/python-igraph/pull-request/3


Also confirmed that pyunicorn builds with this fixed version of python-igraph:

https://copr.fedorainfracloud.org/coprs/ankursinha/pyunicorn/builds/

So, we need to merge that PR, build the fixed igraph, and then build pyunicorn (or do them together in a side tag).

Comment 11 Fedora Update System 2024-09-27 14:47:52 UTC
FEDORA-2024-2004225b17 (python-igraph-0.11.6-3.fc42 and python-pyunicorn-0.7.0~a1-9.20230730gitmaster.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-2004225b17

Comment 12 Fedora Update System 2024-09-27 14:53:37 UTC
FEDORA-2024-2004225b17 (python-igraph-0.11.6-3.fc42 and python-pyunicorn-0.7.0~a1-9.20230730gitmaster.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Fails To Install 2024-10-02 13:50:26 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 41.

Thanks for taking care of it!

Comment 14 Fedora Fails To Install 2025-02-05 12:07:00 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 43.

Thanks for taking care of it!

Comment 15 Aoife Moloney 2025-02-26 13:03:50 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 42 development cycle.
Changing version to 42.

Comment 16 Sandro 2025-03-18 22:08:04 UTC
Build issue was solved a while ago.