Bug 2292378

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7614447
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292378-python-legacy-cgi/fedora-rawhide-x86_64/07614447-python-legacy-cgi/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> # No other tests provided

See https://github.com/jackrosenthal/python-cgi/tree/main/tests

> # The following patch restores a standard python bash
> # that it can then be detected and properly adjusted by the py3_shebang macro

What is a python bash? So you mean shebang?

Anyway, %py3_shebang_fix handles the shebang in that file normally, there is no need for the patch. Call %py3_shebang_fix in %prep instead please.

> %global pypi_name legacy-cgi
> %global pypi_version 2.6

This seems like overkill for a simple specfile like this. Would you consider not defining those macros?


> Source0:        %{pypi_source}

1. Enumeration of a single source is redundant.
2. Using %pypi_source without name argument is deprecated when using the new Python packaging guidelines.

> python3-legacy-cgi.noarch: W: no-documentation

Consider adding %doc README.rst

Thanks, I will correct those points. For tests, I will need to package from a commit, since neither the release or the tag tarball has them.
BTW, do you think the License tag is correct? The license file refers to the Python license, therefore I put the same as python3 package.

Also, does make sense to add a provides python-cgi?

Spec URL: https://mattia.fedorapeople.org/python-legacy-cgi/python-legacy-cgi.spec
SRPM URL: https://mattia.fedorapeople.org/python-legacy-cgi/python-legacy-cgi-2.6%5e20240614.5e15737-1.fc41.src.rpm

Applied fixes for the above comments and added tests.

Created attachment 2037229 [details]
The .spec file difference from Copr build 7614447 to 7614596

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7614596
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292378-python-legacy-cgi/fedora-rawhide-x86_64/07614596-python-legacy-cgi/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> BTW, do you think the License tag is correct? The license file refers to the Python license, therefore I put the same as python3 package.

Yes.


> Also, does make sense to add a provides python-cgi?

Technically, `%py_provides python3-cgi` is desired, as this provides the cgi module. User who see "No module named cgi" might want to `dnf install python3-cgi`.

> 2.6^%{date}.%{shortcommit}

Do we need to include the commit information in the version, if we use the commit just to have tests?

Spec URL: https://mattia.fedorapeople.org/python-legacy-cgi/python-legacy-cgi.spec
SRPM URL: https://mattia.fedorapeople.org/python-legacy-cgi/python-legacy-cgi-2.6%5e20240614.5e15737-1.fc41.src.rpm

Added `%py_provides python3-cgi` to python3-legacy-cgi.

> Do we need to include the commit information in the version, if we use the commit just to have tests?

I usually take that approach for any package which I build from a commit which is not a tag or release.
It seems it's also a MUST do in https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots

Created attachment 2037232 [details]
The .spec file difference from Copr build 7614596 to 7614657

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7614657
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292378-python-legacy-cgi/fedora-rawhide-x86_64/07614657-python-legacy-cgi/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Is this a post-release snapshot, or is it just a way to get around a missing tag?

It's a snapshot from the main branch.
The only available release/tag refer to the time the code was forked from main lib (2 years ago).

Ok then.

Package APPROVED based on the automated fedora review report, spec sanity, build log and package provides/list of files.

python-cgi = 2.6^20240614.5e15737-1.fc41
python-legacy-cgi = 2.6^20240614.5e15737-1.fc41
python3-cgi = 2.6^20240614.5e15737-1.fc41
python3-legacy-cgi = 2.6^20240614.5e15737-1.fc41
python3.13-cgi = 2.6^20240614.5e15737-1.fc41
python3.13-legacy-cgi = 2.6^20240614.5e15737-1.fc41
python3.13dist(legacy-cgi) = 2.6
python3dist(legacy-cgi) = 2.6


/usr/lib/python3.13/site-packages/__pycache__/cgi.cpython-313.opt-1.pyc
/usr/lib/python3.13/site-packages/__pycache__/cgi.cpython-313.pyc
/usr/lib/python3.13/site-packages/__pycache__/cgitb.cpython-313.opt-1.pyc
/usr/lib/python3.13/site-packages/__pycache__/cgitb.cpython-313.pyc
/usr/lib/python3.13/site-packages/cgi.py
/usr/lib/python3.13/site-packages/cgitb.py
/usr/lib/python3.13/site-packages/legacy_cgi-2.6.dist-info
/usr/lib/python3.13/site-packages/legacy_cgi-2.6.dist-info/INSTALLER
/usr/lib/python3.13/site-packages/legacy_cgi-2.6.dist-info/LICENSE
/usr/lib/python3.13/site-packages/legacy_cgi-2.6.dist-info/METADATA
/usr/lib/python3.13/site-packages/legacy_cgi-2.6.dist-info/WHEEL
/usr/share/doc/python3-legacy-cgi
/usr/share/doc/python3-legacy-cgi/README.rst
/usr/share/licenses/python3-legacy-cgi
/usr/share/licenses/python3-legacy-cgi/LICENSE

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-legacy-cgi

FEDORA-2024-961105d7b5 (python-legacy-cgi-2.6^20240614.5e15737-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-961105d7b5

FEDORA-2024-961105d7b5 (python-legacy-cgi-2.6^20240614.5e15737-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.