Bug 2292505

Summary: Review Request: libtatsu - Library handling the communication with Apple's TSS
Product: [Fedora] Fedora Reporter: Davide Cavalca <davide>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/libimobiledevice/libtatsu
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-10-03 23:56:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Davide Cavalca 2024-06-15 15:34:42 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/libtatsu/libtatsu.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/libtatsu/libtatsu-1.0.2-1.fc41.src.rpm

Description:
The libtatsu library allows creating TSS request payloads, sending them to
Apple's TSS server, and retrieving and processing the response.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-06-15 15:34:59 UTC
This needs https://src.fedoraproject.org/rpms/libplist/pull-request/6 to build

Comment 2 Fedora Review Service 2024-06-15 15:36:41 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7617388
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292505-libtatsu/fedora-rawhide-x86_64/07617388-libtatsu/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fedora Review Service 2024-09-03 19:52:52 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7975216
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292505-libtatsu/fedora-rawhide-x86_64/07975216-libtatsu/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Neal Gompa 2024-09-03 19:55:09 UTC
Taking this review.

Comment 6 Neal Gompa 2024-09-03 19:57:55 UTC
(In reply to Davide Cavalca from comment #1)
> This needs https://src.fedoraproject.org/rpms/libplist/pull-request/6 to
> build

can you do a scratch chain build for this to see if it works?

Comment 7 Davide Cavalca 2024-09-03 20:25:11 UTC
I've built it in https://copr.fedorainfracloud.org/coprs/dcavalca/libplist-2.6.0

Comment 8 Neal Gompa 2024-09-03 20:57:30 UTC
Review notes:

* Package follows packaging guidelines
* Package builds and installs
* Package licensing is correct
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 9 Fedora Admin user for bugzilla script actions 2024-09-03 20:58:24 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/libtatsu

Comment 10 Fedora Update System 2024-10-03 22:17:09 UTC
FEDORA-2024-e0671580b1 (clementine-1.4.0~rc2-10.fc42, gvfs-1.56.0-2.fc42, and 16 more) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e0671580b1

Comment 11 Fedora Update System 2024-10-03 23:56:54 UTC
FEDORA-2024-e0671580b1 (clementine-1.4.0~rc2-10.fc42, gvfs-1.56.0-2.fc42, and 16 more) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.