Bug 2293648

Summary: Review Request: qat-zstd-plugin - Intel QuickAssist Technology ZSTD Plugin
Product: [Fedora] Fedora Reporter: Ali Erdinc Koroglu <aekoroglu>
Component: Package ReviewAssignee: Simone Caronni <negativo17>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: negativo17, package-review
Target Milestone: ---Flags: negativo17: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
URL: https://github.com/intel/QAT-ZSTD-Plugin
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-06-21 15:30:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ali Erdinc Koroglu 2024-06-21 13:57:19 UTC
SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/07646772-qat-zstd-plugin/qat-zstd-plugin.spec
SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/07646772-qat-zstd-plugin/qat-zstd-plugin-0.1.0-1.fc41.src.rpm

Description
Intel QuickAssist Technology ZSTD Plugin is a plugin to Zstandard (ZSTD) for accelerating compression by QAT. 

Reproducible: Always

Comment 1 Fedora Review Service 2024-06-21 14:04:02 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7646906
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2293648-qat-zstd-plugin/fedora-rawhide-x86_64/07646906-qat-zstd-plugin/fedora-review/review.txt

Found issues:

- qat-zstd-plugin : /usr/include/qatseqprod.h 
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
- Unversioned so-files directly in %_libdir.
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Simone Caronni 2024-06-21 14:23:00 UTC
Looks good to me.

Package approved, thanks!

Comment 3 Fedora Admin user for bugzilla script actions 2024-06-21 14:33:04 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/qat-zstd-plugin

Comment 4 Ali Erdinc Koroglu 2024-06-21 15:30:03 UTC
Thank you