Bug 2293784
| Summary: | Review Request: rust-cargo_toml - Cargo.toml struct definitions for parsing with Serde | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Beasley <code> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/cargo_toml | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-07-05 20:08:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2293787 | ||
|
Description
Ben Beasley
2024-06-22 16:13:28 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7650892 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2293784-rust-cargo_toml/fedora-rawhide-x86_64/07650892-rust-cargo_toml/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Side note: Any projects that use this crate might want to switch to the official cargo-util-schemas crate. The de/serialization schemas that are used internally by cargo have been split off into a separate project and published as a separate crate *exactly* for use cases where other projects want to parse Cargo.toml files the same way that cargo does it. see also: https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#internal-4 === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (there are no tests) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora 🫤 license file is included with %license in %files (though it's a bit strange to concatenate Apache-2.0 and MIT license texts into a single file) ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Thank you for the review! https://release-monitoring.org/project/373300/ (In reply to Fabio Valentini from comment #2) > Side note: Any projects that use this crate might want to switch to the > official cargo-util-schemas crate. The de/serialization schemas that are > used internally by cargo have been split off into a separate project and > published as a separate crate *exactly* for use cases where other projects > want to parse Cargo.toml files the same way that cargo does it. see also: > https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#internal-4 Thanks for pointing this out. I found that porting was quite practical but slightly less self-contained than I was hoping for, so rather than opening a PR I just filed a detailed suggestion upstream: https://github.com/o2sh/onefetch/issues/1361 The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cargo_toml FEDORA-2024-c3e6c9b664 (rust-cargo_toml-0.20.3-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-c3e6c9b664 FEDORA-2024-09eedc6d55 (rust-cargo_toml-0.20.3-1.fc40, rust-npm-package-json-0.1.3-1.fc40, and 1 more) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-09eedc6d55 FEDORA-2024-9784975a3f (rust-cargo_toml-0.20.3-1.fc39, rust-npm-package-json-0.1.3-1.fc39, and 1 more) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9784975a3f FEDORA-2024-c3e6c9b664 (rust-cargo_toml-0.20.3-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-09eedc6d55 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-09eedc6d55 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-09eedc6d55 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-9784975a3f has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9784975a3f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9784975a3f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-9784975a3f has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9784975a3f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9784975a3f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-09eedc6d55 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-09eedc6d55 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-09eedc6d55 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-fcd37e5b23 (rust-cargo_toml-0.20.3-1.el9, rust-npm-package-json-0.1.3-1.el9, and 2 more) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-fcd37e5b23 FEDORA-EPEL-2024-fcd37e5b23 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-fcd37e5b23 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-09eedc6d55 (rust-cargo_toml-0.20.3-1.fc40, rust-npm-package-json-0.1.3-1.fc40, and 2 more) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-9784975a3f (rust-cargo_toml-0.20.3-1.fc39, rust-npm-package-json-0.1.3-1.fc39, and 2 more) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2024-fcd37e5b23 (rust-cargo_toml-0.20.3-1.el9, rust-npm-package-json-0.1.3-1.el9, and 2 more) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. |