Bug 2293786

Summary: Review Request: rust-npm-package-json - Rust library for parsing npm's package.json file
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: decathorpe: fedora-review+
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/npm-package-json
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-07-03 22:59:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2293787    

Description Ben Beasley 2024-06-22 16:20:41 UTC
Spec URL: https://music.fedorapeople.org/rust-npm-package-json.spec
SRPM URL: https://music.fedorapeople.org/rust-npm-package-json-0.1.3-1.fc40.src.rpm

Description:

A Rust library for parsing npm's `package.json` file.

Fedora Account System Username: music

This is a dependency for the onefetch-manifest crate, part of onefetch, https://github.com/o2sh/onefetch. The spec file is the unmodified output of rust2rpm.

Comment 1 Fedora Review Service 2024-06-22 16:27:00 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7650947
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2293786-rust-npm-package-json/fedora-rawhide-x86_64/07650947-rust-npm-package-json/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-07-03 17:53:04 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Fedora Admin user for bugzilla script actions 2024-07-03 22:21:50 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-npm-package-json

Comment 4 Fedora Update System 2024-07-03 22:57:02 UTC
FEDORA-2024-cb20d63042 (rust-npm-package-json-0.1.3-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-cb20d63042

Comment 5 Fedora Update System 2024-07-03 22:59:26 UTC
FEDORA-2024-cb20d63042 (rust-npm-package-json-0.1.3-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2024-07-05 18:56:50 UTC
FEDORA-2024-09eedc6d55 (rust-cargo_toml-0.20.3-1.fc40, rust-npm-package-json-0.1.3-1.fc40, and 1 more) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-09eedc6d55

Comment 7 Fedora Update System 2024-07-05 19:12:11 UTC
FEDORA-2024-9784975a3f (rust-cargo_toml-0.20.3-1.fc39, rust-npm-package-json-0.1.3-1.fc39, and 1 more) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-9784975a3f

Comment 8 Fedora Update System 2024-07-06 02:26:44 UTC
FEDORA-2024-09eedc6d55 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-09eedc6d55 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-09eedc6d55

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2024-07-06 03:23:04 UTC
FEDORA-2024-9784975a3f has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9784975a3f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9784975a3f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-07-12 04:24:55 UTC
FEDORA-2024-9784975a3f has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9784975a3f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9784975a3f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-07-12 05:29:02 UTC
FEDORA-2024-09eedc6d55 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-09eedc6d55 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-09eedc6d55

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-07-13 00:31:00 UTC
FEDORA-EPEL-2024-fcd37e5b23 (rust-cargo_toml-0.20.3-1.el9, rust-npm-package-json-0.1.3-1.el9, and 2 more) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-fcd37e5b23

Comment 13 Fedora Update System 2024-07-13 02:57:48 UTC
FEDORA-EPEL-2024-fcd37e5b23 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-fcd37e5b23

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2024-07-20 02:25:28 UTC
FEDORA-2024-09eedc6d55 (rust-cargo_toml-0.20.3-1.fc40, rust-npm-package-json-0.1.3-1.fc40, and 2 more) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2024-07-20 03:25:37 UTC
FEDORA-2024-9784975a3f (rust-cargo_toml-0.20.3-1.fc39, rust-npm-package-json-0.1.3-1.fc39, and 2 more) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2024-07-21 00:39:58 UTC
FEDORA-EPEL-2024-fcd37e5b23 (rust-cargo_toml-0.20.3-1.el9, rust-npm-package-json-0.1.3-1.el9, and 2 more) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.