Bug 2293787
| Summary: | Review Request: rust-onefetch-manifest - Detect and parse manifest files | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Beasley <code> | ||||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||||
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://crates.io/crates/onefetch-manifest | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2024-07-11 15:24:26 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 2293784, 2293786 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Ben Beasley
2024-06-22 16:29:59 UTC
Created attachment 2037994 [details]
Configuration file for rust2rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/7650961 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2293787-rust-onefetch-manifest/fedora-rawhide-x86_64/07650961-rust-onefetch-manifest/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. It looks like this crate was either 1) published from an OS without symbolic link support or 2) actually has "../LICENSE.md" as the only contents of the "LICENSE.md" file. (In reply to Fabio Valentini from comment #3) > It looks like this crate was either 1) published from an OS without symbolic > link support or 2) actually has "../LICENSE.md" as the only contents of the > "LICENSE.md" file. Great catch! This also affects the already-reviewed rust-onefetch-ascii and rust-onefetch-image crates. I’ll patch in the correct license file as an additional Source in all three crates and follow up here. I also reported the problem upstream in https://github.com/o2sh/onefetch/issues/1363. New Spec URL: https://music.fedorapeople.org/20240709/rust-onefetch-manifest.spec New SRPM URL: https://music.fedorapeople.org/20240709/rust-onefetch-manifest-2.21.0-1.fc40.src.rpm (In reply to Ben Beasley from comment #5) > New Spec URL: > https://music.fedorapeople.org/20240709/rust-onefetch-manifest.spec > New SRPM URL: > https://music.fedorapeople.org/20240709/rust-onefetch-manifest-2.21.0-1.fc40. > src.rpm No, hold on, still broken. I missed a step. (In reply to Ben Beasley from comment #6) > (In reply to Ben Beasley from comment #5) > > New Spec URL: > > https://music.fedorapeople.org/20240709/rust-onefetch-manifest.spec > > New SRPM URL: > > https://music.fedorapeople.org/20240709/rust-onefetch-manifest-2.21.0-1.fc40. > > src.rpm > > No, hold on, still broken. I missed a step. OK, fixed using the same URLs. Created attachment 2039358 [details]
Updated configuration for rust2rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/7721570 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2293787-rust-onefetch-manifest/fedora-rawhide-x86_64/07721570-rust-onefetch-manifest/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thanks for the update!
> This also affects the already-reviewed rust-onefetch-ascii and rust-onefetch-image crates
/me goes to check if I did these reviews ... oh, good, I didn't :)
I'll re-run the review ...
Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass (some tests justifiably skipped) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files (manually included correct license file from upstream GitHub repo) ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Thank you for the review, and for catching the license-file issue! https://release-monitoring.org/project/373373/ The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-onefetch-manifest FEDORA-2024-70976865d1 (rust-onefetch-manifest-2.21.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-70976865d1 FEDORA-2024-70976865d1 (rust-onefetch-manifest-2.21.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-09eedc6d55 (rust-cargo_toml-0.20.3-1.fc40, rust-npm-package-json-0.1.3-1.fc40, and 2 more) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-09eedc6d55 FEDORA-2024-9784975a3f (rust-cargo_toml-0.20.3-1.fc39, rust-npm-package-json-0.1.3-1.fc39, and 2 more) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9784975a3f FEDORA-2024-9784975a3f has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9784975a3f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9784975a3f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-09eedc6d55 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-09eedc6d55 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-09eedc6d55 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-fcd37e5b23 (rust-cargo_toml-0.20.3-1.el9, rust-npm-package-json-0.1.3-1.el9, and 2 more) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-fcd37e5b23 FEDORA-EPEL-2024-fcd37e5b23 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-fcd37e5b23 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-09eedc6d55 (rust-cargo_toml-0.20.3-1.fc40, rust-npm-package-json-0.1.3-1.fc40, and 2 more) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-9784975a3f (rust-cargo_toml-0.20.3-1.fc39, rust-npm-package-json-0.1.3-1.fc39, and 2 more) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2024-fcd37e5b23 (rust-cargo_toml-0.20.3-1.el9, rust-npm-package-json-0.1.3-1.el9, and 2 more) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. |