Bug 2294109

Cannot find any valid SRPM URL for this ticket. Common causes are:

- You didn't specify `SRPM URL: ...` in the ticket description
  or any of your comments
- The URL schema isn't HTTP or HTTPS
- The SRPM package linked in your URL doesn't match the package name specified
  in the ticket summary


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Spec URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib.spec
SRPM URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib-devel-0.2.0-1.fc38.noarch.rpm

The latest release of the github.com/NVIDIA/go-nvlib module is v0.6.0.  However, anything more recent than v0.2.0 is not compatible with the latest v1.15.0 release of github.com/NVIDIA/nvidia-container-toolkit.  That's why I chose to package only v0.2.0 for the time being.  We can update once there's a newer release of the github.com/NVIDIA/nvidia-container-toolkit module.

(In reply to Debarshi Ray from comment #2)
> Spec URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib.spec
> SRPM URL:
> https://rishi.fedorapeople.org/golang-github-nvidia-nvlib-devel-0.2.0-1.fc38.
> noarch.rpm

Damn, that's not the SRPM.

Spec URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib.spec
SRPM URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib-0.2.0-1.fc38.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7663311
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2294109-golang-github-nvidia-nvlib/fedora-rawhide-x86_64/07663311-golang-github-nvidia-nvlib/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

(In reply to Fedora Review Service from comment #6)
> Copr build:
> https://copr.fedorainfracloud.org/coprs/build/7663311
> (failed)
> 
> Build log:
> https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-
> review-2294109-golang-github-nvidia-nvlib/fedora-rawhide-x86_64/07663311-
> golang-github-nvidia-nvlib/builder-live.log.gz
> 
> Please make sure the package builds successfully at least for Fedora Rawhide.

The build failed with:
No match for argument: golang(github.com/NVIDIA/go-nvml/pkg/dl)
No match for argument: golang(github.com/NVIDIA/go-nvml/pkg/nvml)

That's going to be addressed by the package review of golang-github-nvidia-nvml in bug 2293636

> install --mode 0644 --preserve-timestamps --verbose \
>    pkg/pciids/default_pci.ids \
>    %{buildroot}%{gopath}/src/%{goipath}/pkg/pciids/
> (...)
>%{gopath}/src/%{goipath}/pkg/pciids/default_pci.ids

You can replace this with after `%global godoc`:

%global gosupfiles      pkg/pciids/default_pci.ids

Check golang-github-projectdiscovery-cdncheck.spec or golang-x-crypto.spec as example.

(In reply to Mikel Olasagasti Uranga from comment #8)
> > install --mode 0644 --preserve-timestamps --verbose \
> >    pkg/pciids/default_pci.ids \
> >    %{buildroot}%{gopath}/src/%{goipath}/pkg/pciids/
> > (...)
> >%{gopath}/src/%{goipath}/pkg/pciids/default_pci.ids
> 
> You can replace this with after `%global godoc`:
> 
> %global gosupfiles      pkg/pciids/default_pci.ids
> 
> Check golang-github-projectdiscovery-cdncheck.spec or golang-x-crypto.spec
> as example.

I haven't forgotten about this.  I got swamped wrapping up work before leaving on vacation.  So, I will pick this up once I am back on the 28th of July.

Spec URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib.spec
SRPM URL: https://rishi.fedorapeople.org/golang-github-nvidia-nvlib-0.6.1-1.fc40.src.rpm

I updated it to the latest version of the NVIDIA stack, where everything builds together.

(In reply to Mikel Olasagasti Uranga from comment #8)
> > install --mode 0644 --preserve-timestamps --verbose \
> >    pkg/pciids/default_pci.ids \
> >    %{buildroot}%{gopath}/src/%{goipath}/pkg/pciids/
> > (...)
> >%{gopath}/src/%{goipath}/pkg/pciids/default_pci.ids
> 
> You can replace this with after `%global godoc`:
> 
> %global gosupfiles      pkg/pciids/default_pci.ids

Done.

Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-nvidia-nvlib

Requested Git repository:
https://pagure.io/releng/fedora-scm-requests/issue/67756

Requested Git branches for f41, f40 and f39:
https://pagure.io/releng/fedora-scm-requests/issue/67759
https://pagure.io/releng/fedora-scm-requests/issue/67757
https://pagure.io/releng/fedora-scm-requests/issue/67758

(In reply to Mikel Olasagasti Uranga from comment #11)
>
> [...]
>
> Package approved! On import, don't forget to do the following:

Thanks, Mikel.
 
> - [ ] Add the package to release-monitoring.org
> - [ ] Give go-sig privileges (at least commit) on the package
> - [ ] Close the review bug by referencing its ID in the rpm changelog and
> the Bodhi ticket.
> - [ ] Consider configuring Packit service to help with maintenance

Okay, I will do those.

Added https://github.com/NVIDIA/go-nvlib to Anitya:
https://release-monitoring.org/project/374561/

... and enabled monitoring in Fedora:
https://src.fedoraproject.org/rpms/golang-github-nvidia-nvlib

FEDORA-2024-2f7d355591 (golang-github-nvidia-nvlib-0.6.1-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-2f7d355591

FEDORA-2024-dd8ef6d9f2 (golang-github-nvidia-nvlib-0.6.1-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-dd8ef6d9f2

FEDORA-2024-9eaea5bc2e (golang-github-nvidia-nvlib-0.6.1-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-9eaea5bc2e

FEDORA-2024-9eaea5bc2e has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9eaea5bc2e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9eaea5bc2e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-dd8ef6d9f2 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-dd8ef6d9f2 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-dd8ef6d9f2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-2f7d355591 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-2f7d355591 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-2f7d355591

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-2f7d355591 (golang-github-nvidia-nvlib-0.6.1-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-dd8ef6d9f2 (golang-github-nvidia-nvlib-0.6.1-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-9eaea5bc2e (golang-github-nvidia-nvlib-0.6.1-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.