Bug 2294406

Summary: insecure image registry isn't always properly generated
Product: Red Hat OpenStack Reporter: David Hill <dhill>
Component: openstack-tripleo-commonAssignee: David Hill <dhill>
Status: CLOSED ERRATA QA Contact: David Rosenfeld <drosenfe>
Severity: medium Docs Contact:
Priority: medium    
Version: 17.1 (Wallaby)CC: astupnik, jjoyce, mariel, mburns, ramishra, slinaber
Target Milestone: z4Keywords: Triaged
Target Release: 17.1   
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-tripleo-common-15.4.1-17.1.20240826203739.e5b18f2.el8ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-11-21 09:28:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Hill 2024-06-26 16:20:18 UTC
Description of problem:
insecure image registry isn't always properly generated and we need the following patch to solve this issue:

--- /usr/lib/python3.9/site-packages/tripleo_common/image/image_uploader.py     2023-09-25 20:07:29.000000000 +0000
+++ image_uploader.py 2024-06-25 13:24:24.001079282 +0000
@@ -2081,8 +2081,7 @@
         pull_source = source_url.netloc + source_url.path
         cmd = ['buildah', '--debug', 'pull']

-        if source_url.netloc in [cls.insecure_registries,
-                                 cls.no_verify_registries]:
+        if source_url.netloc in cls.insecure_registries.union(cls.no_verify_registries):
             cmd.append('--tls-verify=false')

         cmd.append(pull_source)

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 3 David Hill 2024-06-27 12:24:50 UTC
Where do I propose the patch ?  downstream or upstream ?

Comment 20 errata-xmlrpc 2024-11-21 09:28:49 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: RHOSP 17.1.4 (openstack-tripleo-common and python-tripleoclient) security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:9991