Bug 2294440

Summary: Review Request: golang-tags-cncf-container-device-interface - Specification for container-runtimes to support third-party devices
Product: [Fedora] Fedora Reporter: Debarshi Ray <debarshir>
Component: Package ReviewAssignee: Mikel Olasagasti Uranga <mikel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mikel, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: mikel: fedora-review+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-07-03 14:17:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Debarshi Ray 2024-06-26 21:06:53 UTC
Spec URL: https://rishi.fedorapeople.org/golang-tags-cncf-container-device-interface.spec
SRPM URL: https://rishi.fedorapeople.org/golang-tags-cncf-container-device-interface-0.7.2-1.fc38.src.rpm

Description:

CDI (Container Device Interface), is a specification, for container-runtimes,
to support third-party devices.

This package contains the source code needed for building packages that
reference the following Go import paths:
 – tags.cncf.io/container-device-interfacCDI (Container Device Interface), is a specification, for container-runtimes,
to support third-party devices.

This package contains the source code needed for building packages that
reference the following Go import paths:
 – tags.cncf.io/container-device-interface

Fedora Account System Username: rishi

Comment 1 Fedora Review Service 2024-06-26 21:13:08 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7672931
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2294440-golang-tags-cncf-container-device-interface/fedora-rawhide-x86_64/07672931-golang-tags-cncf-container-device-interface/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Mikel Olasagasti Uranga 2024-07-02 10:56:04 UTC
This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

Comment 3 Fedora Admin user for bugzilla script actions 2024-07-03 09:40:11 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-tags-cncf-container-device-interface

Comment 4 Debarshi Ray 2024-07-03 09:41:28 UTC
(In reply to Mikel Olasagasti Uranga from comment #2)
>
> [...]
>
> Package approved! On import, don't forget to do the following:

Thanks, Mikel.

> - [ ] Add the package to release-monitoring.org
> - [ ] Give go-sig privileges (at least commit) on the package
> - [ ] Close the review bug by referencing its ID in the rpm changelog and
> the Bodhi ticket.
> - [ ] Consider configuring Packit service to help with maintenance

Okay, I will do those.

Requested Git repository:
https://pagure.io/releng/fedora-scm-requests/issue/63295

Requested Git branches for f40 and f39:
https://pagure.io/releng/fedora-scm-requests/issue/63296
https://pagure.io/releng/fedora-scm-requests/issue/63297

Comment 6 Fedora Update System 2024-07-03 13:49:46 UTC
FEDORA-2024-22ad99493f (golang-tags-cncf-container-device-interface-0.7.2-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-22ad99493f

Comment 7 Fedora Update System 2024-07-03 14:15:54 UTC
FEDORA-2024-baf0302e4f (golang-tags-cncf-container-device-interface-0.7.2-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-baf0302e4f

Comment 8 Fedora Update System 2024-07-04 01:58:18 UTC
FEDORA-2024-22ad99493f has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-22ad99493f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-22ad99493f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2024-07-04 02:01:48 UTC
FEDORA-2024-baf0302e4f has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-baf0302e4f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-baf0302e4f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-07-12 04:18:04 UTC
FEDORA-2024-baf0302e4f (golang-tags-cncf-container-device-interface-0.7.2-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.