Bug 2294727
| Summary: | Review Request: rust-rocket_http - Types, traits, and parsers for HTTP requests, responses, and headers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | wojnilowicz <lukasz.wojnilowicz> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/rocket_http | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-07-07 07:53:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
wojnilowicz
2024-06-28 18:05:30 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7689407 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2294727-rust-rocket_http/fedora-rawhide-x86_64/07689407-rust-rocket_http/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Looks OK to me. Just please clarify some things: - The subpackage for the "mtls" and "x509-parser" features are missing from the package. Are these optional features with additional dependencies that you don't want to package / don't need? - Looks like some doctests can only be run inside the upstream git repository. The doctests you are skipping result in 0 (zero) doctests remaining that are compiled or run. In this case, it would be much, much easier to use `%cargo_test -- --lib` instead of manually listing all source files. (In reply to Fabio Valentini from comment #2) > Looks OK to me. Just please clarify some things: > > - The subpackage for the "mtls" and "x509-parser" features are missing from > the package. > Are these optional features with additional dependencies that you don't > want to package / don't need? Yes. mtls depends on x509-parser, and it isn't available in Fedora. The dependencies that I need are like this (from the top to the bottom): https://github.com/ActivityWatch/aw-server-rust/blob/82345cfc5371c673a9bc2b5284530ae8c180153d/aw-server/Cargo.toml#L17 https://github.com/ActivityWatch/aw-server-rust/blob/82345cfc5371c673a9bc2b5284530ae8c180153d/aw-server/Cargo.toml#L18 https://github.com/lawliet89/rocket_cors/blob/master/Cargo.toml#L23 https://github.com/rwf2/Rocket/blob/v0.5/core/lib/Cargo.toml#L23 https://github.com/rwf2/Rocket/blob/v0.5/core/lib/Cargo.toml#L28 so nothing such fancy as mtls is needed. > - Looks like some doctests can only be run inside the upstream git > repository. The doctests you are skipping result in 0 (zero) doctests > remaining that are compiled or run. In this case, it would be much, much > easier to use `%cargo_test -- --lib` instead of manually listing all source > files. Done. I just wasn't aware of that. Thanks for the tip. The spec file is updated in the first post, so rebuilding. [fedora-review-service-build] Thanks, looks good to me! You might want to replace the comment above "%cargo_test -- --lib" with something more expressive, maybe "doctests can only be run within the upstream workspace" or something like it. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rocket_http FEDORA-2024-2bb31e79d3 (rust-rocket_http-0.5.1-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-2bb31e79d3 FEDORA-2024-2bb31e79d3 (rust-rocket_http-0.5.1-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. Thanks you for the review! Everything's done. |