Bug 2294981

Summary: Missing patch version in "helm version" cmd output
Product: [Fedora] Fedora Reporter: Petr Hruska <petr.hruska>
Component: golang-helm-3Assignee: Davide Cavalca <davide>
Status: CLOSED ERRATA QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: 40CC: davide, dominik, go-sig
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-08-05 01:44:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Petr Hruska 2024-07-01 15:57:48 UTC
When running cmd "helm version" output is
version.BuildInfo{Version:"v3.11", GitCommit:"", GitTreeState:"", GoVersion:"go1.21.6"}

Where Version string is in format v%major.%minor version.

If helm is installed directly from upstream, Version string also contains %patch version.

I can see that LDFLAGS variable is set as "-X helm.sh/helm/v3/version=3.11.1", but that is ignored. Expected LDFLAGS for controlling helm version is "-X helm.sh/helm/v3/internal/version.version=v3.11.1"

Would it be possible to modify spec file to get consistent version output?

Reproducible: Always

Steps to Reproduce:
1.podman run -it --rm fedora:40
2.dnf install helm
3.helm version
Actual Results:  
version.BuildInfo{Version:"v3.11", GitCommit:"", GitTreeState:"", GoVersion:"go1.21.6"}

Expected Results:  
version.BuildInfo{Version:"v3.11.1", GitCommit:"", GitTreeState:"", GoVersion:"go1.21.6"}

Comment 1 Fedora Update System 2024-07-27 19:23:22 UTC
FEDORA-2024-1a2ac99e26 (helm-3.15.3-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-1a2ac99e26

Comment 2 Fedora Update System 2024-07-28 01:39:01 UTC
FEDORA-2024-1a2ac99e26 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-1a2ac99e26`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-1a2ac99e26

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 3 Fedora Update System 2024-08-05 01:44:20 UTC
FEDORA-2024-1a2ac99e26 (helm-3.15.3-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.