Bug 2295879
| Summary: | Review Request: wfview - Control modern Icom radios | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jskarvad, michel, package-review, pemensik |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | michel:
fedora-review?
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://wfview.org | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-11-05 23:51:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2320142 | ||
|
Description
Davide Cavalca
2024-07-05 02:03:12 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=120009799 Copr build: https://copr.fedorainfracloud.org/coprs/build/7712383 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295879-wfview/fedora-rawhide-x86_64/07712383-wfview/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Main license seems to be GPL-3.0-only not -or-later, and there's a weird discrepancy in resampler - the COPYING file says the files are BSD-2-Clause but the files themselves all have BSD-3-Clause headers. Might want to ask upstream and link the issue, but until that is resolved I think keeping both BSD-2-Clause and BSD-3-Clause in the spec as you have is fine. Looks like what's going with resampler is that the specific files are indeed BSD-3-Clause, but the aggregate project is BSD-2-Clause + GPL-2.0-only, so it ends up being the union of those in the end, as I'm not aware of any more specific relicensing just for these components. Given that the combination is compatible this should be ok in the end. Spec URL: https://dcavalca.fedorapeople.org/review/wfview/wfview.spec SRPM URL: https://dcavalca.fedorapeople.org/review/wfview/wfview-1.64-1.fc41.src.rpm Changelog: - update license tag Can you include resampler/COPYING as well? Maybe rename it to resampler-COPYING. That's the only reference to BSD-2-Clause after all. Spec URL: https://dcavalca.fedorapeople.org/review/wfview/wfview.spec SRPM URL: https://dcavalca.fedorapeople.org/review/wfview/wfview-1.64-1.fc41.src.rpm Changelog: - also include resampler license file There seems to be duplicate review of this in bug #2320142. Upstream issue reported: https://gitlab.com/eliggett/wfview/-/issues/147 resampler seems to be bundled version of speexdsp, which we already have in compatible package in Fedora. It should be unbundled and use shared library. jskarvad already tried it and reported it works well. The minimal action would be providing bundled(speexdsp) if not unbundling it. Hi @davide, sorry I missed this review request and unfortunately we have now duplicate review request in bug 2320142. It seems this new review request did more progress, e.g. there is unbundled speexdsp, added wfserver user and systemd wfserver service plus several patches, some already upstreamed, some are waiting for upstream review. If you don't mind I would prefer finishing our review and I am OK to welcome you as a co-maintainer/admin. *** This bug has been marked as a duplicate of bug 2320142 *** |