Bug 2295886

Summary: Review Request: rust-rbw - Unofficial Bitwarden CLI
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-07-06 02:44:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michel Lind 2024-07-05 03:37:36 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-rbw.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-rbw-1.11.1-1.fc41.src.rpm

Description:
Unofficial Bitwarden CLI.

Fedora Account System Username: salimma

Comment 1 Michel Lind 2024-07-05 03:37:58 UTC
Scratch build - https://koji.fedoraproject.org/koji/taskinfo?taskID=120011808

Comment 2 Neal Gompa 2024-07-05 11:33:34 UTC
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- builds and installs
- sources installed with devel package
- binaries installed in unprefixed package

PACKAGE APPROVED.

Comment 3 Fabio Valentini 2024-07-05 11:39:55 UTC
Side note: Does this really provide a usable library interface?
The generated docs look like there's *zero* documentation for any APIs: https://docs.rs/rbw/latest/rbw/

If you don't want to ship the "-devel" files, you can use the "package.cargo-install-lib = false" setting to avoid generating the "-devel" subpackages.

Comment 4 Fedora Admin user for bugzilla script actions 2024-07-05 22:16:30 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rbw

Comment 5 Michel Lind 2024-07-05 22:20:06 UTC
(In reply to Fabio Valentini from comment #3)
> Side note: Does this really provide a usable library interface?
> The generated docs look like there's *zero* documentation for any APIs:
> https://docs.rs/rbw/latest/rbw/
> 
> If you don't want to ship the "-devel" files, you can use the
> "package.cargo-install-lib = false" setting to avoid generating the "-devel"
> subpackages.

Good call, we can disable this for now

https://crates.io/crates/rbw/reverse_dependencies does not show any dependents

Comment 6 Fedora Update System 2024-07-06 02:40:30 UTC
FEDORA-2024-f10864b580 (rust-rbw-1.11.1-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-f10864b580

Comment 7 Fedora Update System 2024-07-06 02:44:27 UTC
FEDORA-2024-f10864b580 (rust-rbw-1.11.1-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2024-07-10 01:01:42 UTC
FEDORA-2024-b527bd8f05 (rust-rbw-1.11.1-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-b527bd8f05

Comment 9 Fedora Update System 2024-07-10 01:01:44 UTC
FEDORA-2024-0c6591451b (rust-rbw-1.11.1-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0c6591451b

Comment 10 Fedora Update System 2024-07-10 01:41:52 UTC
FEDORA-EPEL-2024-b02a734d1a (rust-axum-0.7.5-2.el9, rust-axum-core-0.4.3-1.el9, and 26 more) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-b02a734d1a

Comment 11 Fedora Update System 2024-07-11 00:56:55 UTC
FEDORA-EPEL-2024-b02a734d1a (rust-axum-0.7.5-2.el9, rust-axum-core-0.4.3-1.el9, and 26 more) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2024-07-11 01:15:37 UTC
FEDORA-2024-0c6591451b (rust-rbw-1.11.1-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2024-07-11 01:22:15 UTC
FEDORA-2024-b527bd8f05 (rust-rbw-1.11.1-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.