Bug 2296213

Package for Fedora 40: https://aviram.fedorapeople.org/openspeedtest-1.5-1.noarch.rpm

Sources of this source archive provide fonts, which are already packaged for Fedora in their own packages. It should try to use https://docs.fedoraproject.org/en-US/packaging-guidelines/Web_Assets/ for every resource, which can be shared. Not using everything bundled (again) in its sources. Especially fonts are more restricted and because they are not small, they should not be duplicated. But linked to proper places, if the source would not work with web assets.

Hello,
I do realize that this is possibly an old ticket. I am sorry that it hasn't been
reviewed yet. Let me trigger the Fedora Review Service to see if the package
builds successfully. Hopefully, a green check mark will attract some reviewer.

If I am resurrecting an old ticket that you are not interested in anymore, my
apologies, feel free to close it.

[fedora-review-service-build]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9819682
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296213-openspeedtest/fedora-rawhide-x86_64/09819682-openspeedtest/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Since this started to move, I’ll try to update package later today or in the next days. Thank you

I just installed this last automatic build on my Fedora 43 and it works out of the box.

What is required for this to be accepted in Fedora?

Hi,

I will take this one as nobody has looked at it.

Review to follow.

Regards

Phil

Hi,

* Builds: OK

* No releases or tags upstream. How do we know or be able to confirm validity of release archive?

* No geoloacation selection. Gets my speed very wrong.

* Why does Fedora need another speed test package?

Regards

Phil

This is intended for LAN speed test. Its purpose is to measure speed between your Fedora Server with this package installed and your Windows/Mac/Linux laptop or mobile, specially on a LAN. No Internet connection required or used.

I was not aware of other speed test Fedora package that can do that.
What is its name?

Hi,

The most well known would be 'iperf'[1] in Fedora[2].

I am going to te review back to default as I feel my time would be better spent elsewhere.
This is nothing against this package, but we all have to prioritize our work. I hope
you find someone to help you with your submission.

[1] https://sourceforge.net/projects/iperf2/
[2] https://src.fedoraproject.org/rpms/iperf

Regards

Phil

At a glance:

- If at all possible, the minified JavaScript should be re-created from the original source during the package build: https://docs.fedoraproject.org/en-US/packaging-guidelines/JavaScript/#_compilationminification
- The package needs to use system OTF fonts; packaging fonts elsewhere as web assets is prohibited, https://docs.fedoraproject.org/en-US/packaging-guidelines/Web_Assets/#_fonts, as is packaging “web font formats” like WOFF2 in general. System fonts need to follow an extremely fastidious set of guidelines, https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/.
- As a web application, this would need to follow https://docs.fedoraproject.org/en-US/packaging-guidelines/Web_Assets/, including the prescribed asset paths.
- You should not explicitly set the BuildRoot field nor use the Group field, and you must not use the Packager field: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections.
- You need to document where the source archive comes from, ideally by making it a URL, https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/.