Bug 2296540

Summary: Review Request: rust-tonic - GRPC over HTTP/2 implementation
Product: [Fedora] Fedora Reporter: Cristian Le <fedora>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: decathorpe: fedora-review+
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/tonic
Whiteboard:
Fixed In Version: rust-tonic-0.12.2-2.fc42 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-09-09 11:41:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2296372, 2296539    
Bug Blocks: 2296542, 2297310    

Description Cristian Le 2024-07-09 11:12:47 UTC
Spec URL: https://github.com/LecrisUT/tonic-rpmspec/raw/f7b19948b281b06bae4abaed199dfac901547333/rust-tonic/rust-tonic.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-tonic-rpmspec-main/fedora-rawhide-x86_64/07718144-rust-tonic/rust-tonic-0.12.0-1.fc41.src.rpm
Description: Dependency for `atuin`
Fedora Account System Username: lecris

rust2rpm:
```toml
[features]
enable-all = true

[package]
summary = "GRPC over HTTP/2 implementation"

[requires]
build = [
    "tomcli",
]

[scripts.prep]
post = [
    "# Remove benches",
    "tomcli set Cargo.toml del dev-dependencies.bencher",
    "tomcli set Cargo.toml del bench",
    "rm -r benches benches-disabled",
]
```

Comment 1 Cristian Le 2024-07-30 18:58:24 UTC
[fedora-review-service-build]

Comment 2 Fabio Valentini 2024-07-30 19:34:39 UTC
Adding the review-service rebuild trigger comment doesn't make sense yet - the update landed in rawhide only a few days ago.
COPR builds will only see it ~half a day after the next successful Rawhide compose.

Comment 3 Fabio Valentini 2024-07-30 19:35:08 UTC
Anyway, I will review this package as soon as the dependencies are ready for a test build.

Comment 4 Cristian Le 2024-08-12 16:21:11 UTC
[fedora-review-service-build]

---

Yeah, I just know that the fedora-review service is slow at best, but lately it is completely stuck on my requests.

Comment 5 Cristian Le 2024-08-27 09:58:01 UTC
Spec URL: https://lecris.fedorapeople.org/reviews/rust-tonic/rust-tonic.spec
SRPM URL: https://lecris.fedorapeople.org/reviews/rust-tonic/rust-tonic-0.12.2-1.fc42.src.rpm

Bumped to 0.12.2 and switched to permanent links

Comment 6 Fedora Review Service 2024-08-27 16:03:47 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7947942
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2296540-rust-tonic/fedora-rawhide-x86_64/07947942-rust-tonic/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Fabio Valentini 2024-09-08 13:17:23 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 8 Cristian Le 2024-09-09 07:51:12 UTC
Thank you for the review, Fabio

Comment 9 Fedora Admin user for bugzilla script actions 2024-09-09 07:51:20 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tonic

Comment 10 Fedora Update System 2024-09-09 11:37:38 UTC
FEDORA-2024-6ca6862d34 (rust-tonic-0.12.2-2.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6ca6862d34

Comment 11 Fedora Update System 2024-09-09 11:41:45 UTC
FEDORA-2024-6ca6862d34 (rust-tonic-0.12.2-2.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.