Bug 2297296
|
Description
Nieves
2024-07-11 10:49:50 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7726783 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2297296-tinysparql/fedora-rawhide-x86_64/07726783-tracker/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/tracker Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names - Systemd user unit service file(s) in tracker Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://nmontero.fedorapeople.org/tinysparql.spec SRPM URL: https://nmontero.fedorapeople.org/tinysparql-3.7.3-2.fc41.src.rpm Description: This is a renaming for the package tracker which is being renamed as tinysparql Fedora Account System Username: nmontero As a minimum, the packages inside the spec file should be renamed. Also, the automated review comments should be resolved (you can even run fedora-review locally to get more detailed review comments). Spec URL: https://nmontero.fedorapeople.org/tinysparql.spec SRPM URL: https://nmontero.fedorapeople.org/tinysparql-3.7.3-2.fc41.src.rpm Description: This is a renaming for the package tracker which is being renamed as tinysparql Fedora Account System Username: nmontero You have not updated the packaging in a way that it builds, so please do that as a minimum before asking for review. Spec URL: https://nmontero.fedorapeople.org/tinysparql.spec SRPM URL: https://nmontero.fedorapeople.org/tinysparql-3.8.rc-1.fc42.src.rpm Description: This is a renaming for the package tracker which is being renamed as tinysparql Fedora Account System Username: nmontero Created attachment 2050236 [details]
The .spec file difference from Copr build 7726783 to 8105844
Copr build: https://copr.fedorainfracloud.org/coprs/build/8105844 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2297296-tinysparql/fedora-rawhide-x86_64/08105844-tinysparql/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Systemd user unit service file(s) in tinysparql Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://nmontero.fedorapeople.org/tinysparql.spec SRPM URL: https://nmontero.fedorapeople.org/tinysparql-3.8.rc-1.fc42.src.rpm Description: This is a renaming for the package tracker which is being renamed as tinysparql Fedora Account System Username: nmontero Created attachment 2050252 [details]
The .spec file difference from Copr build 8105844 to 8105966
Copr build: https://copr.fedorainfracloud.org/coprs/build/8105966 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2297296-tinysparql/fedora-rawhide-x86_64/08105966-tinysparql/fedora-review/review.txt Found issues: - Systemd user unit service file(s) in tinysparql Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. A few problems: * the version string needs to include the '~' * no obsoletes or provides according to https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages * includes outdated obsoletes and provides from the original package * includes the old changelog entries * the systemd unit name has not been updated (hence the warning from fedora-review) Spec URL: https://nmontero.fedorapeople.org/tinysparql.spec SRPM URL: https://nmontero.fedorapeople.org/tinysparql-3.8.rc-1.fc42.src.rpm Description: This is a renaming for the package tracker which is being renamed as tinysparql Fedora Account System Username: nmontero There seems to be some problem with the following file. SRPM URL: https://nmontero.fedorapeople.org/tinysparql-3.8.rc-1.fc42.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://nmontero.fedorapeople.org/tinysparql.spec SRPM URL: https://nmontero.fedorapeople.org/tinysparql-3.8~rc-1.fc42.src.rpm Description: This is a renaming for the package tracker which is being renamed as tinysparql Fedora Account System Username: nmontero Created attachment 2050835 [details]
The .spec file difference from Copr build 8105966 to 8113456
Copr build: https://copr.fedorainfracloud.org/coprs/build/8113456 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2297296-tinysparql/fedora-rawhide-x86_64/08113456-tinysparql/fedora-review/review.txt Found issues: - Systemd user unit service file(s) in tinysparql Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Just some easy things left: * Use the macro for bash competion directory: https://docs.fedoraproject.org/en-US/packaging-guidelines/ShellCompletions/ * Could/should use tighter globs on the .so filenames: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files * Missing a separate license field for the doc subpackage (docs/reference/COPYING looks like some kind of MIT) Spec URL: https://nmontero.fedorapeople.org/tinysparql.spec SRPM URL: https://nmontero.fedorapeople.org/tinysparql-3.8~rc-1.fc42.src.rpm Description: This is a renaming for the package tracker which is being renamed as tinysparql Fedora Account System Username: nmontero Created attachment 2051024 [details]
The .spec file difference from Copr build 8113456 to 8117771
Copr build: https://copr.fedorainfracloud.org/coprs/build/8117771 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2297296-tinysparql/fedora-rawhide-x86_64/08117771-tinysparql/fedora-review/review.txt Found issues: - Systemd user unit service file(s) in tinysparql Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://nmontero.fedorapeople.org/tinysparql.spec SRPM URL: https://nmontero.fedorapeople.org/tinysparql-3.8~rc-1.fc42.src.rpm Description: This is a renaming for the package tracker which is being renamed as tinysparql Fedora Account System Username: nmontero Created attachment 2051165 [details]
The .spec file difference from Copr build 8117771 to 8122550
Copr build: https://copr.fedorainfracloud.org/coprs/build/8122550 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2297296-tinysparql/fedora-rawhide-x86_64/08122550-tinysparql/fedora-review/review.txt Found issues: - Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/tinysparql/diff.txt Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ - Systemd user unit service file(s) in tinysparql Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://nmontero.fedorapeople.org/tinysparql.spec SRPM URL: https://nmontero.fedorapeople.org/tinysparql-3.8~rc-1.fc42.src.rpm Description: This is a renaming for the package tracker which is being renamed as tinysparql Fedora Account System Username: nmontero Created attachment 2051186 [details]
The .spec file difference from Copr build 8122550 to 8123099
Copr build: https://copr.fedorainfracloud.org/coprs/build/8123099 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2297296-tinysparql/fedora-rawhide-x86_64/08123099-tinysparql/fedora-review/review.txt Found issues: - Systemd user unit service file(s) in tinysparql Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Plenty of improvements over the original package, and it seems that the systemd scriptlet issue mentioned above is a false positive. Old obsoletes and provides have been removed, and the new ones have correct versions and names, so it is all looking good. The Pagure repository was created at https://src.fedoraproject.org/rpms/tinysparql |