Bug 2297304

Summary: Review Request: rust-axum-server - High level server designed to be used with axum framework
Product: [Fedora] Fedora Reporter: Cristian Le <fedora>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: decathorpe: fedora-review+
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/axum-server
Whiteboard:
Fixed In Version: rust-axum-server-0.6.0-1.fc41 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-07-28 21:57:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2297310    

Comment 1 Fedora Review Service 2024-07-12 03:46:23 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7726792
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2297304-rust-axum-server/fedora-rawhide-x86_64/07726792-rust-axum-server/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-07-13 22:31:51 UTC
Package looks good to me.

Please exclude the examples/self-signed-certs directory from the -devel package though. It looks like it's only useful for the example code.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Cristian Le 2024-07-28 21:19:12 UTC
Thank you for the review, Fabio

Comment 4 Fedora Admin user for bugzilla script actions 2024-07-28 21:19:23 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-axum-server

Comment 5 Fedora Update System 2024-07-28 21:54:20 UTC
FEDORA-2024-c2b3952ef2 (rust-axum-server-0.6.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c2b3952ef2

Comment 6 Fedora Update System 2024-07-28 21:55:05 UTC
FEDORA-2024-c09577f77c (rust-axum-server-0.6.0-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c09577f77c

Comment 7 Fedora Update System 2024-07-28 21:57:30 UTC
FEDORA-2024-c2b3952ef2 (rust-axum-server-0.6.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2024-07-28 22:31:31 UTC
FEDORA-2024-607c98702d (rust-axum-server-0.6.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-607c98702d

Comment 9 Fedora Update System 2024-07-29 01:14:19 UTC
FEDORA-2024-c09577f77c has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c09577f77c`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c09577f77c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-07-29 01:31:51 UTC
FEDORA-2024-607c98702d has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-607c98702d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-607c98702d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-08-06 09:33:08 UTC
FEDORA-2024-c09577f77c (rust-axum-server-0.6.0-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2024-08-06 09:33:17 UTC
FEDORA-2024-607c98702d (rust-axum-server-0.6.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.