Bug 2297308

Summary: Review Request: bash-preexec - preexec and precmd functions for Bash just like Zsh
Product: [Fedora] Fedora Reporter: Cristian Le <fedora>
Component: Package ReviewAssignee: Benson Muite <benson_muite>
Status: ASSIGNED --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: benson_muite, fschwarz, michel, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: benson_muite: fedora-review?
Hardware: All   
OS: Linux   
URL: https://github.com/rcaloras/bash-preexec
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
The .spec file difference from Copr build 7726798 to 8150507 none

Description Cristian Le 2024-07-11 12:31:56 UTC 
Spec URL: https://github.com/LecrisUT/atuin-rpmspec/raw/f63a0e4ad8e84cf1fd4533abacecf3fa353c4936/bash-preexec/bash-preexec.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/SriRamanujam-atuin-rpmspec-7/fedora-rawhide-x86_64/07725265-bash-preexec/bash-preexec-0.5.0-1.20240710160126255333.pr7.32.g00b4fca.fc41.src.rpm
Description: preexec and precmd hook functions for Bash 3.1+ in the style of Zsh. They aim to emulate the behavior as described for Zsh.
Fedora Account System Username: lecris

---

Soft dependency for `atuin`
Comment 1 Cristian Le 2024-07-11 12:53:12 UTC 
Sorry I forgot to disable packit spec file fixes

---

Spec URL: https://github.com/LecrisUT/atuin-rpmspec/raw/b6dea7b78a2d83165c8996c8593bc95092005706/bash-preexec/bash-preexec.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/SriRamanujam-atuin-rpmspec-7/fedora-rawhide-x86_64/07725334-bash-preexec/bash-preexec-0.5.0-1.20240710160126255333.pr7.32.g00b4fca.fc41.src.rpm
Comment 2 Cristian Le 2024-07-11 12:53:51 UTC 
Spec URL: https://github.com/LecrisUT/atuin-rpmspec/raw/b6dea7b78a2d83165c8996c8593bc95092005706/bash-preexec/bash-preexec.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/SriRamanujam-atuin-rpmspec-7/fedora-rawhide-x86_64/07725334-bash-preexec/bash-preexec-0.5.0-1.fc41.src.rpm
Comment 3 Fedora Review Service 2024-07-12 03:20:21 UTC 
There seems to be some problem with the following file.
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/SriRamanujam-atuin-rpmspec-7/fedora-rawhide-x86_64/07725265-bash-preexec/bash-preexec-0.5.0-1.20240710160126255333.pr7.32.g00b4fca.fc41.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 4 Fedora Review Service 2024-07-12 03:24:38 UTC 
There seems to be some problem with the following file.
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/SriRamanujam-atuin-rpmspec-7/fedora-rawhide-x86_64/07725334-bash-preexec/bash-preexec-0.5.0-1.20240710160126255333.pr7.32.g00b4fca.fc41.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 5 Fedora Review Service 2024-07-12 03:29:58 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7726798
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2297308-bash-preexec/fedora-rawhide-x86_64/07726798-bash-preexec/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 6 Cristian Le 2024-10-17 09:23:59 UTC 
Spec URL: https://lecris.fedorapeople.org/reviews/bash-preexec/bash-preexec.spec
SRPM URL: https://lecris.fedorapeople.org/reviews/bash-preexec/bash-preexec-0.5.0-1.fc42.src.rpm

Split the package so that bash-preexec is not sourced for all users by default, unless bash-preexec-all-users is installed. Also changed the return code for non-bash shells to 0.
Comment 7 Fedora Review Service 2024-10-17 12:50:22 UTC 
Created attachment 2052490 [details]
The .spec file difference from Copr build 7726798 to 8150507
Comment 8 Fedora Review Service 2024-10-17 12:50:24 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8150507
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2297308-bash-preexec/fedora-rawhide-x86_64/08150507-bash-preexec/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.