Bug 229755

Summary: pam_succeed_if fails when it should succeed
Product: Red Hat Enterprise Linux 4 Reporter: John Robinson <john.robinson>
Component: pamAssignee: Tomas Mraz <tmraz>
Status: CLOSED DUPLICATE QA Contact: Jay Turner <jturner>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.4CC: srevivo
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-02-23 11:21:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Add upstream "in" and "notin" list matching feature
none
Patch to pam spec to (i) build cleanly and (ii) add list match feature none

Description John Robinson 2007-02-23 07:12:10 UTC 
Description of problem:
I'm trying to get vsftpd only to let people who DON'T have valid shells log in.
To do this, in /etc/pam.d/vsftpd I've changed the line
auth required pam_shells.so
to
auth required pam_succeed_if.so debug shell notin /bin/bash:/bin/sh
And in my logs I get:
Feb 23 06:41:48 cat vsftpd[17824]: pam_succeed_if: 'shell' resolves to
'/usr/libexec/openssh/sftp-server'
Feb 23 06:41:48 cat vsftpd[17824]: pam_succeed_if: requirement "shell notin
/bin/bash:/bin/sh" not met by user "john"
Obviously /usr/libexec/openssh/sftp-server is neither /bin/bash nor /bin/sh, so
I think it ought to have succeeded.

Version-Release number of selected component (if applicable):
pam-0.77-66.17.i386.rpm

How reproducible:
100%

Steps to Reproduce:
1.Make change as described above
2.Change a user's shell so it's not /bin/bash e.g. to /bin/false or whatever
3.Attempt FTP login (which will fail)
4.See /var/log/secure
  
Actual results:
Login fails, bizarre-looking log message

Expected results:
Login succeeds, correct log message

Additional info:
Comment 1 John Robinson 2007-02-23 08:00:10 UTC 
I've followed this up and discovered that the "in" and "notin" feature was only
added in August last year, and isn't present in EL4's PAM, which will be why it
doesn't work. However, I really think the error message ought to say "no such
operator" or something like that, instead of just "requirement not met". Just in
case you're interested, I'll attach a patch to provide the feature (originally
from
http://pam.cvs.sourceforge.net/pam/Linux-PAM/modules/pam_succeed_if/pam_succeed_if.c?r1=1.11&r2=1.12&view=patch
but modified to apply cleanly to your pam-0.77-66.17).
Comment 2 John Robinson 2007-02-23 08:03:10 UTC 
Created attachment 148651 [details]
Add upstream "in" and "notin" list matching feature
Comment 3 John Robinson 2007-02-23 08:11:17 UTC 
Created attachment 148652 [details]
Patch to pam spec to (i) build cleanly and (ii) add list match feature

Build fails with unpackaged files error, so remove them (they're unnecessary
symlinks).
Comment 4 Tomas Mraz 2007-02-23 11:21:32 UTC 

*** This bug has been marked as a duplicate of 173926 ***