Bug 2297710
| Summary: | Review Request: kappanhang - Remotely connect to an Icom RS-BA1 server | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Mikel Olasagasti Uranga <mikel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | mikel, package-review |
| Target Milestone: | --- | Flags: | mikel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-07-17 15:30:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2297707, 2297709 | ||
| Bug Blocks: | |||
|
Description
Davide Cavalca
2024-07-13 16:34:35 UTC
> %{_bindir}/* Avoid using wildcards in the install phase > Name: golang-github-ad8im-kappanhang > (...) > %files -n kappanhang Why not name the package directly kappanhang (go2rpm --name kappanhang) and leave go macros to name the -devel package? Or, if -devel won't be used at all remove `%gopkginstall` and `%gopkgfiles` to create a binary-only package. Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-ad8im-kappanhang/kappanhang.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-ad8im-kappanhang/kappanhang-0-0.1.20240707git9751b53.fc41.src.rpm Changelog: - rename to kappanhang - drop devel package - don't glob Golang Package Review
==============
This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance
Thanks!
The Pagure repository was created at https://src.fedoraproject.org/rpms/kappanhang FEDORA-2024-936382c2ed (kappanhang-0-0.1.20240707git9751b53.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-936382c2ed FEDORA-2024-936382c2ed (kappanhang-0-0.1.20240707git9751b53.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |